Jeremie Courreges-Anglas <j...@wxcvbn.org> writes: > Nils Reuße <n.reu...@hxgn.net> writes: > >> On 04/13/2017 08:28 PM, Jeremie Courreges-Anglas wrote: >>> Nils Reuße <n.reu...@hxgn.net> writes: >>> >>>> In an attempt to write some hangul on OpenBSD, i updated some ports ;) >>>> Here is an update for libhangul. Included is an upstream patch [1], >>>> which i found while checking the freebsd port. >>>> >>>> Alongside goes a new port ibus-hangul (please see my other mail). >>>> I bumped the major lib version to 1, because that's what ibus-hangul >>>> expects. >>>> >>>> Any comments? >>> >>> Your diff was mangled (tab->spaces + some line wraps); don't copy/paste >>> diffs, better "include" them if your MUA supports that, or send them as >>> attachments. >>> >>> Note that the shared lib version should be have a major bump because >>> several symbols have been removed, not because that's what ibus-hangul >>> expects. See >>> >>> https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs >>> >>> Here's a reworked diff with the following changes: >>> - work around the tarball naming using DISTFILES >>> - don't use the gettext module (which should probably be marked as >>> deprecated) >>> >>> >> >> Hi Jeremie, >> >> thanks for looking into it! I had never heard of DISTFILES before, the >> Makefile looks much better now ;) And thanks for your explanations, >> they're much appreciated. > > Sure. Looks like scim-hangul is still happy at build time with the > updated libhangul; and looks like scim-hangul works fine says ktrace(1), > I guess this libhangul update could go in. If someone that uses scim > could confirm that scim-hangul still works, that would be great. :)
No report, but I've committed this anyway. Thanks! -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
