On Tue, Oct 10 2017, Remi Locherer <remi.loche...@relo.ch> wrote: > On Mon, Oct 09, 2017 at 03:02:49PM -0400, Daniel Jakots wrote: >> On Sat, 7 Oct 2017 23:21:31 +0200, Remi Locherer >> <remi.loche...@relo.ch> wrote: >> >> > Hi, >> > >> > this is an update for vdirsyncer to version 0.16.3 which was released >> > few days ago. See >> > https://vdirsyncer.pimutils.org/en/stable/changelog.html for changes. >> > >> > This patch also enables tests and shortens some long lines in >> > Makefile. >> >> lgtm >> >> > The tests depend on two python modules that are not available in ports >> > yet. py-test-localserver >> >> it needs requests as a TDEP, can you put MODPY_PI and MODPY_SETUPTOOLS >> just after MODULES please? > > Thanks for spotting this! Attached the fixed ports.
Looks good to me. Two nits in py-test-subtesthack: - s/an/and in COMMENT - the bdep on devel/py-setuptools_scm doesn't seem to be needed? With this addressed, ok jca@ to import py-test-localserver and py-test-subtesthack, and ok for the vdirsyncer update. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
