On 2018/01/05 15:53, Klemens Nanni wrote:
> On Fri, Jan 05, 2018 at 03:15:22PM +0100, Björn Ketelaars wrote:
> > On Thu 04/01/2018 23:27, Klemens Nanni wrote:
> > > You can build it with SEPARATE_BUILD=Yes.
> >
> > The build of borgbackup still works with SEPARATE_BUILD=Yes, however I'm not
> > sure that it makes sense to set this variable. With this variable set
> > nothing
> > is build in the separate generated ${WRKBUILD} directory.
> > Guess that Python's setuptools doesn't care.
> My bad, I did only half the job.
>
> setup.py accepts a parameter called --build-base but SEPARATE_BUILD
> doesn't automatically effect it's usage:
>
> $ make -p SEPARATE_BUILD=yes | grep ^MODPY_DISTUTILS_BUILD
> MODPY_DISTUTILS_BUILD = build --build-base=${WRKSRC}
>
> So in order to actually make use of it, you need
>
> MODPY_DISTUTILS_BUILD =›build
> MODPY_DISTUITLS_BUILDARGS=--build-base ${WRKBUILD}
>
> > My proposal would be to leave out the SEPARATE_BUILD bit, and keep the diff
> > as
> > is.
> Updated diff attached. Builds fine, tests are still running but seem all
> fine so far.
That sort of scaffolding is not something that should be done in an
individual port, if it's done anywhere it should be in python.port.mk.
Though realistically Python things aren't usually big enough for
SEPARATE_BUILD to be much of a win.
