On Sat, Jan 13, 2018 at 12:08:25AM +0200, Timo Myyrä wrote:
> pre-patch:
> find ${WRKSRC} -type f | \
> - xargs sed -i 's,^JAR =.*,JAR = ${JAVA_HOME}/bin/jar,g'
> + xargs fgrep -l "JAR =" | \
> + xargs sed -i 's,^JAR =.*,JAR = ${JAVA_HOME}/bin/jar,g'; \
That seems overly complicated to me. find can do what xargs does here,
running two xargs just makes it worse and after all there's no need for
grep. Since you'll encounter only one "JAR =..." assignment per line,
sed's `g' flag can be dropped as well.
Might be nitpicking but how about this (untested):
find ${WRKSRC} -type f -exec \
sed -i '/^JAR =/s,=.*,= ${JAVA_HOME}/bin/jar,' {} +
