On Fri, Jan 26, 2018 at 09:13:17AM +0200, Timo Myyrä wrote: > > Klemens Nanni <k...@posteo.org> writes: > >> Paths in the example dunst.rc need to be adjusted so copying it over > >> will work without manually fixing them. Yuck, I forgot to include those in my earlier diff, sorry.
> Here is an updated diff to include patching the dunstrc file and pod doc. Except for a few nits below this diff looks good to me. > Index: Makefile > =================================================================== > RCS file: /cvs/ports/x11/dunst/Makefile,v > retrieving revision 1.3 > diff -u -p -r1.3 Makefile > --- Makefile 31 Aug 2017 20:57:00 -0000 1.3 > +++ Makefile 26 Jan 2018 07:11:14 -0000 > @@ -29,11 +27,13 @@ LIB_DEPENDS += devel/gettext \ There are two spaces after += instead of a tab. > devel/pango \ > graphics/cairo \ > graphics/gdk-pixbuf2 \ > - x11/gtk+2 \ > x11/libxdg-basedir \ > x11/dbus I'd still move dbus up to sort them alphabetically as done in my earlier diff. > MAKE_FLAGS = V=1 PREFIX="${PREFIX}" MANPREFIX="${PREFIX}/man" Not a big fan of those squashed ones, they're better readable across multiple lines as done for *_DEPENDS (also makes future diffs easier).