On Sun, Feb 11, 2018 at 09:20:08AM +0100, Björn Ketelaars wrote: > On Sun 11/02/2018 09:11, Landry Breuil wrote: > > On Sun, Feb 11, 2018 at 08:56:18AM +0100, Björn Ketelaars wrote: > > > After more than 2 years json-c received an update, which fixes quite > > > some issues. Most noticeable changes have been listed in > > > https://github.com/json-c/json-c/blob/master/ChangeLog > > > > > > I bumped the major number of SHARED_LIB as functions have been added, > > > and removed. HOMEPAGE has been updated as the original one is not > > > reachable. > > > > > > There is no need for patching in detection of > > > __sync_val_compare_and_swap as this has been resolved upstream: > > > > > > https://github.com/json-c/json-c/commit/0539191d187050faad0ed2657cddfd411e4c7900#diff-b1c3915d42e849f17e1ddf2d95111063 > > > > > > Output 'make test': > > > > > > # TOTAL: 21 > > > # # PASS: 21 > > > # # SKIP: 0 > > > # # XFAIL: 0 > > > # # FAIL: 0 > > > # # XPASS: 0 > > > # # ERROR: 0 > > > > > > Of the 23 victims of devel/json-c I only tested net/isc-bind > > > (rndc-confgen to be more precise), which seems to work ok. It would be > > > great if more people could check if this update works for them. > > > > I suppose that means "i've built all of them but only runtime-tested > > bind", right ? :) > > ...not exactly. Let me rephrase the last bit: > > I only built tested 2 victims, and runtime tested isc-bind.
Right. In the past json-c has proven itself "interesting" when upgrading it, so i'll put this diff in my next bulk along cmake stuff.