> > Sorry to make you do more work, but: > > 1. Could you eliminate -Werror in all the patches? It's in one but not the > > other. > > > > 2. There are some more -O3 floating around. For example: > > Thanks for reviewing! > > I missed the remaining -O3, and didn't think that using -Werror is not > preferred. Output 'make test' after removing these flags: > > 100% tests passed, 0 tests failed out of 30 > > Instead of patching 4 files I'm using sed.
I think it's fair enough to use sed for this. OK with me The main problem with -Werror is that some of the older compilers warn on things which newer ones find acceptable, so you're at risk of builds failing needlessly on the very arches where it's harder to get tests done.
