On 2018/03/17 08:33, Klemens Nanni wrote:
> Numerous critical bugs have piled up including data corruption, see
> https://raw.githubusercontent.com/antirez/redis/4.0/00-RELEASENOTES
> 
> Works fine in my setup, all tests passing on amd64.
> 
> Patches have been dropped or simplified a lot by passing variables
> through MAKE_ENV or adding to post-install instead,
> patch-src_mkreleasehdr_sh was useless on its own already.
> 
> Whitespace fixes, switch to HTTPS and minor reordering included, too.
> 
> Feedback? OK?

It's a lot to change in one go. The version update makes sense, but
I'm not sure about the rest of the shuffling (and in any event,
that sort of thing is better separated from a routine update).

> -MASTER_SITES =               http://download.redis.io/releases/
> +MASTER_SITES =               https://download.redis.io/releases/

curl: (7) Failed to connect to download.redis.io port 443: Connection refused

> +MAKE_FLAGS =         DEBUG=${DEBUG} \
> +                     DEBUG_FLAGS=${DEBUG} \
> +                     DEPENDENCY_TARGETS="hiredis linenoise" \
> +                     INSTALL_SBIN="${PREFIX}/sbin" \
> +                     MALLOC=libc \
> +                     OPT= \
> +                     OPTIMIZATION= \
>                       V=1

Overrides seem sensible for things like DEBUG (but should be quoted).
For things like DEPENDENCY_TARGETS it's better if a change in the upstream
Makefile causes a patch failure during an update because it will need to
be adapted anyway.

How about just

Index: Makefile
===================================================================
RCS file: /cvs/ports/databases/redis/Makefile,v
retrieving revision 1.100
diff -u -p -r1.100 Makefile
--- Makefile    11 Jan 2018 19:27:02 -0000      1.100
+++ Makefile    17 Mar 2018 09:49:31 -0000
@@ -1,10 +1,9 @@
 # $OpenBSD: Makefile,v 1.100 2018/01/11 19:27:02 rpe Exp $
 
 COMMENT =              persistent key-value database
-DISTNAME =             redis-4.0.2
+DISTNAME =             redis-4.0.8
 CATEGORIES =           databases
-HOMEPAGE =             http://redis.io/
-REVISION =             0
+HOMEPAGE =             https://redis.io/
 
 MAINTAINER =           David Coppa <[email protected]>
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/databases/redis/distinfo,v
retrieving revision 1.78
diff -u -p -r1.78 distinfo
--- distinfo    22 Sep 2017 05:46:35 -0000      1.78
+++ distinfo    17 Mar 2018 09:49:31 -0000
@@ -1,2 +1,2 @@
-SHA256 (redis-4.0.2.tar.gz) = saCRXbyRuXnQbfGXf+WUw/qbGJ8fPTh0OilIyfdjSBM=
-SIZE (redis-4.0.2.tar.gz) = 1713990
+SHA256 (redis-4.0.8.tar.gz) = /ww4uMFWMZJJ/sYeUBjPW1/mOmW2FpC+x5j0yZjCMq0=
+SIZE (redis-4.0.8.tar.gz) = 1729973

Reply via email to