On 2018/04/11 15:29, Aaron Bieber wrote: > On Wed, Apr 11, 2018 at 10:09:12PM +0100, Stuart Henderson wrote: > > On 2018/04/11 22:39, Frederic Cambus wrote: > > > Hi ports@, > > > > > > Here is a diff to drop Tokyo Cabinet storage support, this greatly > > > speeds up processing time, more than 10 times actually. > > > > > > With the current version: > > > > > > - Total Requests: 1,347,757 > > > - Log Size: 282.49 MiB > > > - Init. Proc. Time: 712 secs > > > > > > With the diff applied: > > > > > > - Total Requests: 1,347,757 > > > - Log Size: 282.49 MiB > > > - Init. Proc. Time: 67 secs > > > > > > While there, switch HOMEPAGE and MASTER_SITES to HTTPS and update > > > license marker to specify the MIT license, which goaccess switched > > > to since the 1.0 release. > > > > > > Comments? OK? > > > > It is expected that goaccess is slower with Tokyo Cabinet (it's clear > > in the manpage), but it allows it to process larger files, and to keep > > data in persistent storage. > > > > I'm not a fan of unnecessary flavours in ports, but I think this might > > be a case where it makes sense? > > I would like it if there was a non-tokyo flavor. It has only ever > caused problems for me. That said, I am not a very heavy user of it!
I would suggest using a flavour to _enable_ tokyocabinet rather than on-by-default. Maybe with a quick explanation why one might want to use it in DESCR.
