On 2018/04/26 12:00, Solene Rapenne wrote:
> I added a pkg/README-main with following content

That text reads well to me. By the way, for the extra file, you can "cvs
add" and then "cvs diff -uN" will include it.

> > make port-lib-depends-check says:
> >
> >   tome4-1.5.7(games/tome4,-main):
> >   Missing: c++abi.0 (/usr/local/bin/tome4) (system lib)
> >   WANTLIB += c++abi
> >
> > I thought c++abi would come from the embedded luajit but I can't find
> > any reference to it in the tome4 source code.
> >
> > This already happens with tome4-1.5.5, so it's not a showstopper, but it
> > would be nice to understand what's going on.  ok jca@
> 
> c++ comes from the web module and the new discord api. I added the
> c++abi to WANTLIB

I'm not sure if this is the cause, there are c++ files but I don't see them
being compiled, and I'd expect libc++ as well in that case.

It seems more likely that the embedded luajit is the reason, c++abi is
needed for unwind on clang arches. I don't see how it's being pulled in
here, but whatever the reason it should be in WANTLIB, but only on clang
arches, so please make it conditional:

.include <bsd.port.arch.mk>
.if ${PROPERTIES:Mclang}
WANTLIB += c++abi
.endif

Reply via email to