On Fri, 27 Apr 2018 12:10:03 +0200, Klemens Nanni <k...@openbsd.org> wrote:
> On Thu, Apr 26, 2018 at 08:15:10PM +0200, Klemens Nanni wrote: > > Finally picked up that old diff. Tests on amd64 say > > > > Ran 4 test cases in 1.18s (1.07s CPU) > > All 28 modules OK > > > > Upstream ditched their GUI quite some ago. You'll need some quirks for the pkg change, can you show them please? Comments inline > Index: Makefile > =================================================================== > RCS file: /cvs/ports/devel/pylint/Makefile,v > retrieving revision 1.24 > diff -u -p -r1.24 Makefile > --- Makefile 26 Mar 2017 11:21:52 -0000 1.24 > +++ Makefile 27 Apr 2018 10:09:50 -0000 > @@ -1,60 +1,50 @@ > # $OpenBSD: Makefile,v 1.24 2017/03/26 11:21:52 shadchin Exp $ > > -RUN_DEPENDS= devel/py-astroid${MODPY_FLAVOR} \ > - devel/py-isort${MODPY_FLAVOR} \ > +RUN_DEPENDS = devel/py-astroid${MODPY_FLAVOR}>=1.3.9 \ > + devel/py-isort${MODPY_FLAVOR}>=4.2.5 \ > devel/py-mccabe${MODPY_FLAVOR} \ > devel/py-six${MODPY_FLAVOR} Any reason to add these version requirements? > devel/pylint${MODPY_FLAVOR}=${MODPY_EGG_VERSION} > -TEST_DEPENDS= ${RUN_DEPENDS} \ > - devel/py-logilab-common${MODPY_FLAVOR}>=1.3.0 > +TEST_DEPENDS = ${RUN_DEPENDS} \ > + > devel/py-logilab-common${MODPY_FLAVOR}>=0.19.0 Lowering the version requirement doesn't really make sense in our context. > -do-test: fake > +test: fake Why this change? It breaks make test if you don't have the tdep. > post-install: > - rm > ${WRKINST}${MODPY_SITEPKG}/pylint/test/unittest_lint.py.orig Can you add it back? Otherwise in the PLIST there is +lib/python${MODPY_VERSION}/site-packages/pylint/test/unittest_lint.py.orig