On Mon, 07 May 2018 13:51:38 +0200, Jeremie Courreges-Anglas wrote: > On Sun, May 06 2018, Klemens Nanni <k...@openbsd.org> wrote: > > Simple diff for out-of-tree builds: > > > > $ du -sh `make show='WRKSRC WRKBUILD'` > > 27.8M /tmp/pobj/tor-0.3.2.10/tor-0.3.2.10 > > 94.4M /tmp/pobj/tor-0.3.2.10/build-amd64 > > > > Without the symlink, it would rebuild manuals using rst2man. > > > > OK? > > I'm not sure I like introducing workarounds for something like > SEPARATE_BUILD=Yes. I'd rather fix the problem in tor (or at least > report it) so that out-of-tree builds work out of the box in an upcoming > version. > > Anyway, Pascal has the final word here, no strong objection on my side.
Seconded. I don't think SEPARATE_BUILD=Yes is high priority enough to warrant extra hoop-jumping. > > Index: Makefile > > =================================================================== > > RCS file: /cvs/ports/net/tor/Makefile,v > > retrieving revision 1.112 > > diff -u -p -r1.112 Makefile > > --- Makefile 25 Apr 2018 12:54:15 -0000 1.112 > > +++ Makefile 6 May 2018 10:01:17 -0000 > > @@ -17,6 +17,7 @@ WANTLIB += c crypto event_core event_ext > > MASTER_SITES= https://www.torproject.org/dist/ > > > > AUTOCONF_VERSION=2.69 > > +SEPARATE_BUILD= Yes > > CONFIGURE_STYLE=autoconf > > # PIE is already taken care of on a per-arch basis, and we have stack > > protection > > # anyway on FRAME_GROWS_DOWN archs. > > @@ -32,5 +33,8 @@ DB_DIR= /var/tor > > SUBST_VARS+= DB_DIR > > > > FAKE_FLAGS= sysconfdir=${PREFIX}/share/examples > > + > > +pre-build: > > + ln -sf ${WRKSRC}/doc ${WRKBUILD}/ > > > > .include <bsd.port.mk> > > > > -- > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
