On 2018/05/23 23:53, Brian Callahan wrote:
> Hi ports --
>
> This is my "portroach rampage" contribution of the day, which is a new term
> I just learned. It is a mostly straightforward update of misc/redshift. I
> say mostly, because I noticed that while redshift was compiling with cc, it
> was linking with gcc -- it looks for your Objective-C compiler and uses that
> as the linker (and apparently defaults to gcc). But the override is trivial.
>
> OK?
Not sure about forcing OBJC=$CC... Seems better to restore the Makefile.in
section to how it was in 1.11 for now and check with upstream? This was
introduced when adding MacOS CoreLocation support.
Index: src/Makefile.in
--- src/Makefile.in.orig
+++ src/Makefile.in
@@ -661,7 +661,7 @@ windows/versioninfo.$(OBJEXT): windows/$(am__dirstamp)
redshift$(EXEEXT): $(redshift_OBJECTS) $(redshift_DEPENDENCIES)
$(EXTRA_redshift_DEPENDENCIES)
@rm -f redshift$(EXEEXT)
- $(AM_V_OBJCLD)$(OBJCLINK) $(redshift_OBJECTS) $(redshift_LDADD) $(LIBS)
+ $(AM_V_CCLD)$(LINK) $(redshift_OBJECTS) $(redshift_LDADD) $(LIBS)
mostlyclean-compile:
-rm -f *.$(OBJEXT)
Also: configure picks up geoclue2 if present at build time.
