On 2018/06/03 17:19, Edward Lopez-Acosta wrote:
> Hello,
>
> Had a previous thread on this but the packages had some errors. Sorry if I
> should have replied to that thread, still getting used to the mailing list.
>
> py-progressbar is a separate port unrelated to this one. They are not
> compatible nor does this one upgrade it.
>
> I have attached the latest tarballs for these ports.
> Would it be possible to please get some testing and a dev to merge this into
> the ports tree if all is well?
>
> Thank you in advance.
Just commenting on progressbar2, but the same things apply to python-utils:
:: # $OpenBSD$
::
:: COMMENT = Python library to provide visual progress
line up after the = with tabs not spaces (here and on other lines)
(8 column tab width)
::
:: DISTNAME = progressbar2-${MODPY_EGG_VERSION}
:: PKGNAME = ${MODPY_PY_PREFIX}${DISTNAME}
no need to use ${MODPY_PY_PREFIX}, this is handled automatically. just set
PKGNAME = py-${DISTNAME}
::
:: CATEGORIES = devel
::
:: # BSD 3-clause
:: PERMIT_PACKAGE_CDROM = Yes
::
:: MODULES = lang/python
:: TEST_DEPENDS = devel/py-test${MODPY_FLAVOR}, \
shouldn't have the trailing , (same in RUN_DEPENDS)
:: devel/py-six${MODPY_FLAVOR}
similar to "=<tab>", at the start of a line just use tabs
::
:: FLAVORS += python3
:: FLAVOR ?=
::
:: NO_BUILD = Yes
::
:: PKG_ARCH = *
for standard python ports don't use NO_BUILD (they do usually do something
in the "build" stage which just gets pushed out to the "install" stage if you
skip build), or PKG_ARCH=*.
::
:: MODPY_EGG_VERSION = 3.37.1
please put this up the top with DISTNAME
:: MODPY_SETUPTOOLS = Yes
:: MODPY_PI = Yes
:: RUN_DEPENDS = devel/py-python_utils${MODPY_FLAVOR}, \
:: devel/py-six${MODPY_FLAVOR}
try to line columns up a bit more, you won't get it to be
perfect without wasting a lot of horizontal space, but as you'll see
in other ports they're generally consistent within a block of lines
next to each other
::
:: .include <bsd.port.mk>
In pkg/PLIST ${MODPY_COMMENT} should only be on the line for the
directory i.e.
${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/progressbar/${MODPY_PYCACHE}
Basically ${MODPY_PYCACHE} expands to nothing in py2 (because the .pyc files
are right alongside the .py files in the same directory), and something in py3
(a subdirectory is used). ${MODPY_COMMENT} is used to knock out that
subdirectory
line for py2 packages to avoid a duplicate entry in PLIST.
So with the extra lines with ${MODPY_COMMENT} in your port, you're
removing the pyc files from the py2 package, but those files should be
installed.
