On Sat, Jun 30, 2018 at 09:24:08PM +0200, Kristaps Dzonsons wrote: > >>> and now that sqlite2mdoc is in, here's the diff for the integration part > >>> into sqlite3 port. Note the less that 10% size increase in pkg size. > >>> > >>> 1953518 sqlite3-3.24.0.tgz > >>> 2187305 sqlite3-3.24.0p0.tgz > >> > >> The unpacked size isn't too much bigger either. OK sthen > >> > >> Kristaps: one nit with sqlite2mdoc which jumped out at me on the first > >> page I randomly picked to see how it looks - the "new sentence new line" > >> mechanism results in a newline after "e.g." which means you get a double > >> space. > >> > >> "new sentence new line" makes more sense for manuals which are > >> edited/diffed than these generated pages, so I'm wondering if it would > >> be acceptable to disable this heuristic? (just remove the lines around > >> 1415). It would still miss things if it appears on the end of a source > >> line, or if we're unlikely with long-line splitting, but it does help > >> the common case in the sqlite comments which is "If some other error > >> occurs (e.g. an OOM condition)" and appears quite often. > >> > >> Example page with this is sqlite3changeset_old(3) but there are a lot > >> more. > > > > I went through and looked at all nl/ns instances and found only e.g. and > > i.e. as being obviously wrong, so I special-cased them. One-letter > > combos were overwhelmingly variables in a sentence, so I didn't touch that. > > > > Port updated as enclosed. > > Now without forgotten debugging information. Sorry for the churn. This > is for 0.1.4.
Thanks. Just committed the update. > Index: Makefile > =================================================================== > RCS file: /cvs/ports/converters/sqlite2mdoc/Makefile,v > retrieving revision 1.2 > diff -u -p -r1.2 Makefile > --- Makefile 29 Jun 2018 18:11:44 -0000 1.2 > +++ Makefile 30 Jun 2018 19:21:31 -0000 > @@ -2,7 +2,7 @@ > > COMMENT = extract C reference manpages from SQLite3 header file > > -DISTNAME = sqlite2mdoc-0.1.2 > +DISTNAME = sqlite2mdoc-0.1.4 > > MAINTAINER = Kristaps Dzonsons <krist...@bsd.lv> > > Index: distinfo > =================================================================== > RCS file: /cvs/ports/converters/sqlite2mdoc/distinfo,v > retrieving revision 1.1.1.1 > diff -u -p -r1.1.1.1 distinfo > --- distinfo 29 Jun 2018 17:16:14 -0000 1.1.1.1 > +++ distinfo 30 Jun 2018 19:21:31 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (sqlite2mdoc-0.1.2.tar.gz) = > ie5oLMnjvs38fn5HosVCU6ENV+Qhja21h+DcUDApITw= > -SIZE (sqlite2mdoc-0.1.2.tar.gz) = 27697 > +SHA256 (sqlite2mdoc-0.1.4.tar.gz) = > 328K3uGgTje6rZ2HnRriT64Od7KdWdV870yjj8Tf0W8= > +SIZE (sqlite2mdoc-0.1.4.tar.gz) = 27896 -- James Turner
