Hi Kristaps, Kristaps Dzonsons BSD.LV wrote on Sun, Aug 05, 2018 at 06:51:10PM +0200:
> Enclosed is another iteration with the changes as specifically noted > below. The last port didn't compile with an existing grantlee and it > crashed on start---I think this had to do with the FB changes, but am > not sure. > > The enclosed port builds, installs, and runs with all functionality with > a coexisting libdivecomputer and non-qt5 grantlee. Tested by connecting > to the cloud, printing (well, to PDF), connecting to a dive computer. Great, so i'm now looking for OKs to import both ports for real: * misc/subsurface as in this mail i'm replying to * misc/libdivecomputer as in my last mail (4 Aug 2018 17:29:42) > So, here is where I disagree. UpdateManager is one thing---it's not > useful, because the user doesn't manage updates. Same with being nagged > to take the survey. > > But I don't think it's correct to remove functionality that depends upon > user choice. I don't use FB myself, but many do and that's their > choice. It doesn't do anything when not being used. Not sure that's entirely true - i got a very noticeable delay during first startup with your version that i didn't get with mine, and i assume that's related to some kind of network activity, though admittedly i did not investigate with tcpdump and/or ktrace. > Same with the ability to participate in the user survey. So in the > enclosed, I leave both enabled, with the latter patched not to be > in nag mode. Fair enough as a maintainer choice, i think. So let's just go with your version. My review of your patches and my minimal testing (mainly that it builds and starts up properly) confirms that it's good to go. Yours, Ingo
