On 2018/08/20 19:55, Edward Lopez-Acosta wrote:
Hello all,
Simple version update for www/py-requests to 2.19.1, contacted maintainer
but did not hear back so submitting here. Copied the port to mystuff/ before
making the changes, hopefully that does not affect too much.
It's often better to not copy to mystuff for updates, if you forget to
remove it later you can run into problems with the wrong version being used.
Failing tests are for the Pipfile which is not included in the package as
its just for development. I would not mind extra eyes on this though.
Diffs below and pending feedback.
Thank you in advance.
--- /usr/ports/www/py-requests/distinfo Mon Aug 20 19:47:17 2018
+++ /usr/ports/mystuff/www/py-requests/distinfo Mon Aug 20 19:47:55 2018
@@ -1,2 +1,2 @@
-SHA256 (requests-2.18.4_1.tar.gz) =
nEQ+cyS6W4UHDEqBit4ov6vt8W6hAgbaETLtqm3aI34=
-SIZE (requests-2.18.4_1.tar.gz) = 126224
+SHA256 (requests-2.19.1_1.tar.gz) =
7CLYJqNu1ypzWP8/5Wy9S6ad16Zxj/1FD/Dp33pHzmo=
+SIZE (requests-2.19.1_1.tar.gz) = 131068
Your diff is word-wrapped and has tabs converted to spaces, so
doesn't apply with patch. Might be simpler to attach it as a file,
but preferably use a mail client that doesn't mangle diffs and either
include it inline as a file into the editor, or use something like
"diff | xclip" and paste it in to preserve tabs.
(Also by working in ports/www/py-requests directly, you can send a
cvs diff which, unlike a plain diff between two files, includes
version information).
--- /usr/ports/www/py-requests/Makefile Mon Aug 20 19:47:13 2018
+++ /usr/ports/mystuff/www/py-requests/Makefile Mon Aug 20 19:46:43 2018
@@ -2,7 +2,7 @@
COMMENT= elegant and simple HTTP library for Python
-MODPY_EGG_VERSION= 2.18.4
+MODPY_EGG_VERSION= 2.19.1
DISTNAME= requests-${MODPY_EGG_VERSION}
PKGNAME= py-${DISTNAME}
REVISION= 0
REVISION should be removed.
--- /usr/ports/www/py-requests/pkg/PLIST Thu Jul 26 19:02:41 2018
+++ /usr/ports/mystuff/www/py-requests/pkg/PLIST Mon Aug 20 19:48:26
2018
@@ -1,4 +1,4 @@
-@comment $OpenBSD: PLIST,v 1.12 2018/01/21 23:20:10 jung Exp $
+@comment $OpenBSD: PLIST,v$
lib/python${MODPY_VERSION}/site-packages/requests/
lib/python${MODPY_VERSION}/site-packages/requests-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/
lib/python${MODPY_VERSION}/site-packages/requests-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO
@@ -8,7 +8,7 @@ lib/python${MODPY_VERSION}/site-packages/requests-${MO
lib/python${MODPY_VERSION}/site-packages/requests-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt
lib/python${MODPY_VERSION}/site-packages/requests-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
lib/python${MODPY_VERSION}/site-packages/requests/__init__.py
-${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/requests/${MODPY_PYCACHE}/
+lib/python${MODPY_VERSION}/site-packages/requests/${MODPY_PYCACHE}
MODPY_COMMENT should be kept, by removing it the python 2 version
won't package, which makes me wonder what you've actually tested
with this update?
lib/python${MODPY_VERSION}/site-packages/requests/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
lib/python${MODPY_VERSION}/site-packages/requests/${MODPY_PYCACHE}__version__.${MODPY_PYC_MAGIC_TAG}pyc
lib/python${MODPY_VERSION}/site-packages/requests/${MODPY_PYCACHE}_internal_utils.${MODPY_PYC_MAGIC_TAG}pyc
--
Edward Lopez-Acosta
py-requests is used by approx 30 ports so this will need some kind of
review to assess the chance of breaking them. (I think it's unlikely,
but definitely wants an eye over it - as we're now approaching OpenBSD
release there will be less time to discover and fix any problems found,
so we need to make sure that any potential risk is checked out early).
