On Thu, Nov 01, 2018 at 12:05:14PM +0000, Ricardo Mestre wrote:
> Hi,
> 
> st has a key combination ctrl+shift+i which calls dmenu, straight from the
> manpage:
> 
> Ctrl-Shift-i
>       Launch dmenu to enter a unicode codepoint and send the
>       corresponding glyph to st.
> 
> Due to pledge missing exec this doesn't work and I actually prefer it that 
> way,
> nevertheless this leaves a new core dump laying around everytime you press the
> combination. The patch below just removes the combination instead of the whole
> function iso14755.
> 
> OK?

Shouldn't you patch the man page as well?

> 
> Index: patches/patch-config_def_h
> ===================================================================
> RCS file: /cvs/ports/x11/st/patches/patch-config_def_h,v
> retrieving revision 1.9
> diff -u -p -u -r1.9 patch-config_def_h
> --- patches/patch-config_def_h        17 Mar 2018 13:28:39 -0000      1.9
> +++ patches/patch-config_def_h        1 Nov 2018 11:53:32 -0000
> @@ -11,3 +11,11 @@ Index: config.def.h
>   
>       /* 8 bright colors */
>       "gray50",
> +@@ -177,7 +177,6 @@ static Shortcut shortcuts[] = {
> +     { TERMMOD,              XK_V,           clippaste,      {.i =  0} },
> +     { TERMMOD,              XK_Y,           selpaste,       {.i =  0} },
> +     { TERMMOD,              XK_Num_Lock,    numlock,        {.i =  0} },
> +-    { TERMMOD,              XK_I,           iso14755,       {.i =  0} },
> + };
> + 
> + /*
> 

-- 
Antoine

Reply via email to