On 2018/11/28 08:25, Martijn van Duren wrote:
> On 11/27/18 2:36 PM, Daniel Jakots wrote:
> > On Tue, 27 Nov 2018 12:43:52 +0100, Martijn van Duren
> > <openbsd+po...@list.imperialat.at> wrote:
> >
> >> Here's an update to databases/py-carbon.
> >> There's experimental support for python3, but I haven't included it
> >> here because of other dependencies which don't yet have python3
> >> support in our tree.
> >
> > Which one(s)?
> >
> I must have goofed somewhere. It's not py-carbon directly which has
> "issues", but py-whisper. But let's safe that discussion for that
> threat.
>
> Here's an updated diff. I don't know whether mostly executable
> python packages should be moved to python3, or if they still
> should come in flavors, so I just made it a flavor, so we can
> quite easily dumb it down again if we just want python3.
If it's actually useful as a library then it might be worth considering
whether to subpackage it - have the executables as a separate package
only built with the python3 flavour.
But if (as COMMENT implies) it's only really useful as daemon/utilties
then I'd much prefer to just switch to py3 outright. This cuts a lot of
complexity from Makefile, patches and PLIST, and makes it so all users
are on recent python (rather than the "default" being old python).
> Note: carbon-aggregator{,-cache} doesn't work because it misses
> py-cachetools, but people could get that themselves via pip, or it
> could be added as a package in the future, so I left the plumbing in
> as is.
Hmm. People shouldn't be installing via pip to make packages work3
I'd prefer to either port the dep, or @comment the files that need it.
> @@ -108,3 +121,13 @@ share/examples/graphite/whitelist.conf.e
> @sample /var/graphite/storage/whisper/
> @owner
> @group
> +storage/
> +storage/ceres/
> +storage/ceres/dummy.txt/
> +storage/lists/
> +storage/log/
> +storage/log/dummy.txt/
> +storage/rrd/
> +storage/rrd/dummy.txt/
> +storage/whisper/
> +storage/whisper/dummy.txt/
It feels like these /usr/local/storage directories should not be installed,
they are already @sample'd under /var/graphite/storage so I think should just
be rm'd. But there are some missing @extra or @extraunexec that would be
needed for pkg_delete -c to correctly remove files generated in this tree.
