I ve redone the patch but I think I did already the bump change (if it is LIBV variable used for ?). Regards. On Mon, 10 Dec 2018 at 10:02, David CARLIER <devne...@gmail.com> wrote: > > Hi I was just reading your answer ... I think I did the bump jump already ? > > ie from 3.0 to 3.1 (var LIBV) or did you mean something else ? > On Sun, 9 Dec 2018 at 22:49, Stuart Henderson <s...@spacehopper.org> wrote: > > > > On 2018/12/09 15:43, Edd Barrett wrote: > > > On Sun, Dec 09, 2018 at 05:36:21AM +0000, David CARLIER wrote: > > > > Hi, > > > > > > > > there is an update for radare2 and radare2-bindings. > > > > Some functions are no longer exported in some the libraries, this > > requires the library major to be bumped. > > > > From ports faq, > > > > "The rules for shared libraries are quite simple. > > > > - If functions were added to the library, you must bump the library > > minor number: a program that needs those functions has no way to require > > it except by asking explicitly for at least this version. > > > > - If the existing API changes, that is, if any function signature is > > altered, or if valid calling sequences are no longer valid, if a type > > changes in an incompatible way, the library major number must be bumped. > > > > - This includes removing old functions. Any function removal should > > trigger a major number bump." > > > > There is also an offset when applying patch-libr_Makefile which suggests > > patches haven't been updated properly. > > > > : Patching file libr/Makefile using Plan A... > > : Hunk #1 succeeded at 213 (offset 12 lines). > > : done > > > > > Looks good diff-wise, but the build fails for me. > > > > > > (I don't have the old version installed) > > > > > > I'm running: > > > OpenBSD 6.4-current (GENERIC.MP) #493: Wed Dec 5 22:00:48 MST 2018 > > > > It does build ok for me on amd64 here. (It's one of those annoying ports > > that fails if the old version is installed but that's a different error). > > > > Full working build log at https://junkpile.org/radare2-3.1.0.log if you > > want to diff and see if anything becomes apparent .. > > > > > ---8<--- > > > ... > > > gmake -C binr > > > gmake[1]: Entering directory > > > '/usr/local/pobj/radare2-3.1.0/radare2-3.1.0/binr' > > > gmake[2]: Entering directory > > > '/usr/local/pobj/radare2-3.1.0/radare2-3.1.0/binr/rax2' > > > cc -c -O2 -pipe -O2 -pipe -O2 -pipe -MD -fPIC -g -Wall -D__UNIX__=1 > > > -O2 -pipe -MD -fPIC -g -Wall -D__UNIX__=1 -O2 -pipe -MD -fPIC -g > > > -Wall -D__UNIX__=1 > > > -I/usr/local/pobj/radare2-3.1.0/radare2-3.1.0/libr/..//libr/include -o > > > rax2.o rax2.c > > > cc -O2 -pipe -O2 -pipe -O2 -pipe -MD -fPIC -g -Wall -D__UNIX__=1 -O2 > > > -pipe -MD -fPIC -g -Wall -D__UNIX__=1 -O2 -pipe -MD -fPIC -g -Wall > > > -D__UNIX__=1 > > > -I/usr/local/pobj/radare2-3.1.0/radare2-3.1.0/libr/..//libr/include > > > rax2.o -L.. -o rax2 -L/usr/local/lib -lpthread -lm > > > -L/usr/local/pobj/radare2-3.1.0/radare2-3.1.0/libr/util -lr_util -fPIC > > > -lz -lzip > > > /usr/bin/ld: error: undefined symbol: ret_ascii_table > > > >>> referenced by rax2.c:75 > > > >>> rax2.o:(rax) > > > > > > /usr/bin/ld: error: undefined symbol: r_hex_from_code > > > >>> referenced by rax2.c:391 > > > >>> rax2.o:(rax) > > > > > > /usr/bin/ld: error: undefined symbol: r_print_hex_from_bin > > > >>> referenced by rax2.c:469 > > > >>> rax2.o:(rax) > > > cc: error: linker command failed with exit code 1 (use -v to see > > > invocation) > > > --->8--- > > > > > > -- > > > Best Regards > > > Edd Barrett > > > > > > http://www.theunixzoo.co.uk > > > > > > >
patch-radare2.diff
Description: Binary data
