Hey Paco,

On Thu, Dec 13, 2018 at 12:01:12PM +0100, Paco Esteban wrote:
> Thanks Solène for your suggestion.
> Here's the updated port.

Port-wise, I have one comment. I'd remove NO_TEST=Yes. Although there are no
tests, it still succeeds to invoke the test target. If tests are added in a
later release, we will run them without having to flip NO_TEST.

I found a crash:

---8<---
Welcome to VF-1!                                                                
                                                                                
[103/1991]
Enjoy your flight through Gopherspace...
VF-1> go sdf.org
Welcome to the SDF Public Access UNIX System .. est. 1987

Official Site of the Internet Gopher Club Underground Syndicate

We offer FREE and inexpensive memberships for people interested
in the UNIX system and internetworking.  Personal GOPHERSPACE
is available to all users as well as hundreds of UNIX utilities,
games and networking utilities.  We are a federally recognized
non-profit 501(c)7 organization and we are supported entirely
by donations and membership dues.  ssh://sdf.org

[1] SDF PHLOGOSPHERE (275 phlogs)/
[2] SDF GOPHERSPACE (1276 ACTIVE users)/
[3] SDF GOPHERSPACE (1363 AGED users)/
[4] SDF GOPHERSPACE (372 ANCIENT users)/
[5] SDF Frequently Asked Questions (FAQ)/
[6] SDF Accredited University Courses/
[7] Software and Documentation for various computers/
[8] GopherSpace SEARCH Engine <INP>
[9] Floodgap's GOPHERSPACE/
____________________________________________________________________________
                     Gophered by Gophernicus/101 on NetBSD/amd64 8.0_STABLE
VF-1> 8
Query term: france
[1] Floodgap Systems gopher root/

Veronica-2 2.058.2 (C)2000-2016 Cameron Kaiser
Engine version 0.4.051
** Search in progress, please wait **

*** Search terms: france ***
First 30 selectors displayed (page 1).
Results sorted by apparent relevance.
Approximately 300 total matches.

[2] Enter new search keywords <INP>
[3] Folders/directories are least accurate! (and other notes)

[4] Refining your query

------------------------------------------------------------

[5] France/
gopher://therandymon.com:70/1/Travel/France
[6] France/
gopher://dictatorshandbook.net:70/1/Travel/France
[7] FFDN: A Federation of DIY-ISPs in France and Belgium/
gopher://gopher.raumzeitlabor.org:70/1/event/4956
[8] 2018 _ bitreichcon in Rodez, France/
gopher://bitreich.org:70/1/con/2018
[9] Francis.Bacon/
gopher://gopher.std.com:70/11/The Online Book Initiative/Francis.Bacon
[10] France/
gopher://gopher.std.com:70/11/The Online Book Initiative/Anthems/France
[11] [09-Jun-2011]          france/
gopher://sdf.org:70/1/users/france/
[12] [23-Jan-2006]         francis/
...
[34] France
gopher://gopherpedia.com:70/0/France

------------------------------------------------------------

[35] Enter new search keywords <INP>
[36] Back to the beginning/
[37] Next 30 matches/
VF-1>
[1] Floodgap Systems gopher root/
[2] Enter new search keywords <INP>
[3] Folders/directories are least accurate! (and other notes)
[4] Refining your query
[5] France/
[6] France/
[7] FFDN: A Federation of DIY-ISPs in France and Belgium/
Traceback (most recent call last):
  File "/usr/local/bin/vf1", line 11, in <module>
    load_entry_point('VF-1==0.0.10', 'console_scripts', 'vf1')()
  File "/usr/local/lib/python3.6/site-packages/vf1.py", line 1004, in main
    gc.cmdloop()
  File "/usr/local/lib/python3.6/cmd.py", line 138, in cmdloop
    stop = self.onecmd(line)
  File "/usr/local/lib/python3.6/cmd.py", line 204, in onecmd
    return self.emptyline()
  File "/usr/local/lib/python3.6/site-packages/vf1.py", line 796, in emptyline
    self.show_lookup(offset=i, end=i+10)
  File "/usr/local/lib/python3.6/site-packages/vf1.py", line 500, in show_lookup
    print(self._format_gopheritem(n+offset+1, gi, name, url))
UnicodeEncodeError: 'ascii' codec can't encode character '\u2013' in position 
9: ordinal not in range(128)
--->8---

(Before the crash, I pressed enter on a blank line to page the long list
of results)

Good old Python3 and unicode...

--
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk

Reply via email to