OK sthen@
On 2018/12/19 21:04, George Rosamond wrote: > > > Stuart Henderson: > > On 2018/12/10 16:44, George Rosamond wrote: > >> > >> > >> Anthony J. Bentley: > >>> George Rosamond writes: > >>>> pkg/DESCR: > >>>> > >>>> Mada is a modernist, low-contrast Arabic typeface based largely on > >>>> the typeface seen in Cairo metro old signage which was designed by > >>>> Professor Fathi Gouda of Faculty of Applied Arts, Helwan University. > >>>> > >>>> Mada is characterised by low descenders, open contours and low- > >>>> contrast forms making it suitable for small point sizes, user > >>>> interfaces, signage or low resolution settings. > >>>> > >>>> Mada can work also as a display typeface giving modernist and > >>>> simplistic feeling. > >>>> > >>>> Mada comes in 7 weights (ExtraLight, Light, Regular, Medium, SemiBold, > >>>> Bold and Black), as well as an interpolatable variable font that > >>>> can provide any intermediate weight on the fly. > >>> > >>> Two small things. > >>> > >>> One, DESCR is a little narrow. 80-ish columns would be better. > >> > >> odd that happened. Fixed. > >> > >>> > >>>> MASTER_SITES = https://github.com/alif-type/mada/archive/ > >>> > >>> We prefer "/releases/download/" URLs if they exist, and one exists > >>> for this port (Mada-1.3.zip on the releases page). The reason is that > >>> "/archive/" tarballs are generated on the fly and do not have stable > >>> checksums. > >>> > >>> With those two small changes, this is ok with me. > >> > >> Got it. > >> > >> Attached. Thanks Anthony.. > >> > >> g > > > > The distfile is 404. Diff on top of what you sent to fix: > > > > diff --git Makefile Makefile > > index b6474e4..2daeba2 100644 > > --- Makefile > > +++ Makefile > > @@ -3,7 +3,7 @@ > > COMMENT = modernist Arabic typeface > > > > V = 1.3 > > -DISTNAME = v${V} > > +DISTNAME = Mada-${V} > > PKGNAME = mada-${V} > > > > CATEGORIES = fonts > > @@ -13,7 +13,7 @@ MAINTAINER = George Rosamond <geo...@nycbug.org> > > # SIL OFL 1.1 > > PERMIT_PACKAGE_CDROM = Yes > > > > -MASTER_SITES = > > https://github.com/alif-type/mada/releases/download/ > > +MASTER_SITES = > > https://github.com/alif-type/mada/releases/download/v${V}/ > > > > MODULES = font > > > > @@ -22,11 +22,10 @@ NO_TEST = Yes > > > > FONTDIR = ${PREFIX}/share/fonts/mada > > DOCDIR = ${PREFIX}/share/doc/mada > > -WRKDIST = ${WRKDIR}/${PKGNAME} > > > > do-install: > > ${INSTALL_DATA_DIR} ${FONTDIR} ${DOCDIR} > > ${INSTALL_DATA} ${WRKDIST}/*.otf ${FONTDIR} > > - ${INSTALL_DATA} ${WRKDIST}/README.md ${DOCDIR} > > + ${INSTALL_DATA} ${WRKDIST}/README.txt ${DOCDIR} > > > > .include <bsd.port.mk> > > diff --git distinfo distinfo > > index 273b3d6..4d4ffd1 100644 > > --- distinfo > > +++ distinfo > > @@ -1,2 +1,2 @@ > > -SHA256 (v1.3.zip) = G2+BwXpVl6fCBrhJRdsEL2wRUqZtvRrEZR6lrp/q2VA= > > -SIZE (v1.3.zip) = 633890 > > +SHA256 (Mada-1.3.zip) = c6EVKXgXMJhd30vb8Y8t9Yurxz0K5yqHrjiEEMcbCzc= > > +SIZE (Mada-1.3.zip) = 370287 > > diff --git pkg/PLIST pkg/PLIST > > index 8c73284..8e32dae 100644 > > --- pkg/PLIST > > +++ pkg/PLIST > > @@ -1,6 +1,6 @@ > > @comment $OpenBSD: PLIST,v$ > > share/doc/mada/ > > -share/doc/mada/README.md > > +share/doc/mada/README.txt > > share/fonts/ > > @fontdir share/fonts/mada/ > > share/fonts/mada/Mada-Black.otf > > > > Ok. I believe the attached is correct. > > Thanks > > g
