On Fri, Dec 21, 2018 at 10:43:32PM +0100, Rafael Sadowski wrote:
> On Fri Dec 21, 2018 at 09:55:49PM +0100, Juan Francisco Cantero Hurtado wrote:
> > I'm moving grlida to qt5, so kili@ can remove poppler-qt4.
> > 
> > The update works for me but I would like the confirmation from someone
> > else. Any volunteer?.
> > 
> 
> Sure! Please find attached a new diff with following changes:
> 
> - remove COMPILER and x11/qt5/qtbase from LIB_DEPENDS; This coms from
>   the qt5 MODULE.
> - use qmake MODULE instead doing it by hand.
> - I've changed everything from es_ES to en_EN. (Maybe not correct)
> 
> The following still has to be fixed:
> 
> In file included from ../3rdparty/osdab-zip/zip.cpp:29:
> ../3rdparty/osdab-zip/zip_p.h:65:13: error: unknown type name 'z_crc_t'
>     typedef z_crc_t crc_t;
>             ^
> ../3rdparty/osdab-zip/zip.cpp:286:16: error: assigning to 'const 
> ZipPrivate::crc_t *' (aka 'const int *') from incompatible type 'const uLongf 
> *' (aka 'const unsigned long *')
>     crcTable = get_crc_table()
> 
> Please note that the patches do not have UNIX line breaks so your in-place 
> diff
> was not clean.

Thanks for the help. I added your changes to the makefile but it doesn't
generate the executable. Also, I forgot to add the patch for osdab-zip
to the previous patch.

About the change es -> en. That's only needed in one line for the
language selector in the first run.

Updated diff attached.


-- 
Juan Francisco Cantero Hurtado http://juanfra.info

Attachment: grlida.patch.gz
Description: application/gzip

Reply via email to