I had this update from nearly 1yr ago...

$ cvs -R -q diff -uNp
Index: Makefile
===================================================================
RCS file: /home/cvs/ports/www/p5-HTML-Tree/Makefile,v
retrieving revision 1.28
diff -u -p -r1.28 Makefile
--- Makefile    1 May 2017 19:54:18 -0000       1.28
+++ Makefile    11 Feb 2018 22:55:22 -0000
@@ -4,7 +4,7 @@ COMMENT=        perl parser that builds an HTML

 MODULES=       cpan
 PKG_ARCH=      *
-DISTNAME =     HTML-Tree-5.06
+DISTNAME =     HTML-Tree-5.07
 CATEGORIES=    www

 # Perl
Index: distinfo
===================================================================
RCS file: /home/cvs/ports/www/p5-HTML-Tree/distinfo,v
retrieving revision 1.11
diff -u -p -r1.11 distinfo
--- distinfo    1 May 2017 19:54:18 -0000       1.11
+++ distinfo    11 Feb 2018 22:49:21 -0000
@@ -1,2 +1,2 @@
-SHA256 (HTML-Tree-5.06.tar.gz) =
nDbrGcvfmlkGyFiUjKUcNb11YfUswYxDKBrL5XMnU24=
-SIZE (HTML-Tree-5.06.tar.gz) = 150067
+SHA256 (HTML-Tree-5.07.tar.gz) =
8DdNuEcxwgS4bB1bkJdf7w0wqGvZ3vkZND5VTjGp278=
+SIZE (HTML-Tree-5.07.tar.gz) = 150477

The tests passed here on amd64 using the above.

You shouldn't add p5-libwww without changing the BUILD/RUN_DEPENDS to
only include p5-libwww for runtime, this stops p5-libwww and all it's
run time dependencies having to be built first on build machines, it has
a lot of dependencies.

Additionally it also promotes some bad habits of not including the
dependencies starting to rely on p5-HTML-Tree rather than including
p5-libwww as a dependency, and also if include p5-libwww alone you don't
get https support you need to add p5-LWP-Protocol-https not p5-libwww

p5-libwww used to include https support but was split into a number of
separate modules.

Something being in the ports tree doesn't make it a reason to include if
it's only recommended. Your taking away the option from the end user of
the ports of deciding if something is actually needed.



On 01/07/19 22:34, Charlene Wendling wrote:
> 
> I'm proposing here an update for HTML::Tree. The only change is a fix
> that allow building with newer Perl versions [1].
> 
> What's new in port: 
> 
> - make use of TEST_POD instead of using TEST_DEPENDS
> - added www/p5-libwww, that was already present in 5.06. It's only a
>   recommended module, but we have it in the tree anyway. Not sure if 
>   we want it, but it allows fetching a HTML document directly from
>   an URL, which is quite handy for such a module ;) 
>   
>   The recommended HTML::Formatter is not in the port tree, it's the
>   successor of of the now "dead" devel/p5-HTML-Format [2]. Sure we'll
>   have to update the whole stack around it sooner or later, but there
>   has been no issue with 5.06 that recommended it already. 
> 
> Testing: 
> 
> - 'make test' passes 
> - There are consumers, i've found no new failures [3], but please note
>   that KDE4's extras haven't been firmly tested. It should go without
>   issues anyway, because the only changes are really in Build.PL and
>   distribution files [4].
> 
> Charlène. 
> 
> [1] https://metacpan.org/source/KENTNL/HTML-Tree-5.07/Changes
> [2]
> https://github.com/nigelm/html-formatter/commit/f72de441df4e2159db255bb147bebdbff3273309
> [3] https://transfer.sh/oMGfA/p5-HTML-Tree.tgz
> [4] https://github.com/kentfredric/HTML-Tree/commits/master
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/www/p5-HTML-Tree/Makefile,v
> retrieving revision 1.28
> diff -u -p -u -p -r1.28 Makefile
> --- Makefile  1 May 2017 19:54:18 -0000       1.28
> +++ Makefile  7 Jan 2019 21:24:20 -0000
> @@ -4,21 +4,23 @@ COMMENT=    perl parser that builds an HTML
>  
>  MODULES=     cpan
>  PKG_ARCH=    *
> -DISTNAME =   HTML-Tree-5.06
> +DISTNAME =   HTML-Tree-5.07
>  CATEGORIES=  www
>  
>  # Perl
>  PERMIT_PACKAGE_CDROM=        Yes
>  
>  RUN_DEPENDS= www/p5-HTML-Parser>=3.46 \
> -             www/p5-HTML-Tagset>=3.02
> +             www/p5-HTML-Tagset>=3.02 \
> +             www/p5-libwww
>  BUILD_DEPENDS=       ${RUN_DEPENDS} \
>               devel/p5-Test-Fatal
>  
>  CONFIGURE_STYLE =    modbuild
>  
> -TEST_DEPENDS=                devel/p5-Test-Pod \
> -                     devel/p5-Test-LeakTrace \
> -                     devel/p5-Try-Tiny
> +TEST_DEPENDS=        devel/p5-Test-LeakTrace \
> +             devel/p5-Try-Tiny
> +
> +MAKE_ENV +=  TEST_POD=Yes
>  
>  .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/www/p5-HTML-Tree/distinfo,v
> retrieving revision 1.11
> diff -u -p -u -p -r1.11 distinfo
> --- distinfo  1 May 2017 19:54:18 -0000       1.11
> +++ distinfo  7 Jan 2019 21:24:20 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (HTML-Tree-5.06.tar.gz) = nDbrGcvfmlkGyFiUjKUcNb11YfUswYxDKBrL5XMnU24=
> -SIZE (HTML-Tree-5.06.tar.gz) = 150067
> +SHA256 (HTML-Tree-5.07.tar.gz) = 8DdNuEcxwgS4bB1bkJdf7w0wqGvZ3vkZND5VTjGp278=
> +SIZE (HTML-Tree-5.07.tar.gz) = 150477
> 
> 

Reply via email to