On Sat, Jan 19 2019, Thomas Frohwein <tfrohw...@fastmail.com> wrote: > On Sat, Jan 19, 2019 at 10:29:53AM +0100, Jeremie Courreges-Anglas wrote: > [...] >> - the Makefile diff doesn't apply, it seems like it has been produced >> before the latest commit to sdl2-image/Makefile. > > My bad, the dir in mystuff was from an outdated checkout. > >> - no change in public headers and no exported symbol added/removed, says >> check_sym, so the shared lib bump isn't needed > [...] >> - libsamplerate is an indirect dependency brought in by libSDL2.la. It >> shouldn't be listed in LIB_DEPENDS. >> >> Not sure how useful the remaining LIB_DEPENDS change below is, but you >> won't be able to push it to -stable since 6.4 only has sdl2-2.0.8. > > I added that because it released with sdl2-2.0.9 and didn't account for > how that would prevent working with -stable. I can't find anything on a > minimum sdl2 version for sdl2-images-2.0.4, so leaving it as is for now. > > New diff taking all of these points into account here below. ok?
Yup, ok jca@ (also for -stable) -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
