On 2019/03/15 19:45, Frederic Cambus wrote:
> This looks good to me, a few nitpicks inline below.
> With those addressed, OK fcambus@.
> 
> > +For consoles on a drm(4) device, a font may only be loaded if it matches
> > +the size of the current console font. For displays with a width above
> > +1920 and belove 3840 pixels, rasops(9) will select a 16x32 font which
>             ^^^^^^
> You have a typo here: s/belove/below.

Thanks, fixed in my tree.

> > +can be replaced with one of the "ter-132*" fonts. (Terminus does not
> > +have a 32x64 font to match the size used by default on wider displays).
> > +
> > +This can be loaded and configured like so:
> > +
> > +$ wsfontload -N ter-132n -w 16 -h 32 
> > /usr/local/share/misc/pcvtfonts/ter-132n
>                                         ^^^^^^^^^^
> portcheck complains about an hardcoded path here :)

And this.

> > +$ wsconsctl display.font=ter-132n
> > +
> > +To return to the default console font:
> > +
> > +$ wsconsctl display.font="Spleen 16x32"
> 
> Both wsfontload and wsconsctl must be run as root, so maybe we should
> change $ to # for the prompts?

That isn't currently the case. If the kernel is changed to require
this I'll happily switch it over.

What do you think Daniel, is this ok with you?

Reply via email to