On 2019/03/18 08:23, Landry Breuil wrote: > On Mon, Mar 18, 2019 at 12:09:01AM +0100, Charlene Wendling wrote: > > > > > http://build-failures.rhaalovely.net/powerpc/last/geo/qlandkartegt.log > > > http://build-failures.rhaalovely.net/sparc64/2019-02-03/geo/qlandkartegt.log > > > > So this one needs -std=c++11. Once provided there is the usual > > <cmath>/<math.h> fight later during the build. I tried to be > > conservative here, but anyway upstream moved to a remake of its own > > software called QMapShack. > > > > It builds fine on macppc [1] and amd64 [2]. I don't have the > > hardware to fully test it, but geotiff maps are fine. > > > > Any comment? > <snip> > > > +# fix error: #error Must have C++11 or newer. > > +# XXX this should be retried once moving to ports-gcc>=8 > > removed :) retired isnt right either i think.. > otherwise looks good. > > Landry >
'reviewed' is probably the best word, but 'retried' is understandable and matches the wording in other ports. hopefully it won't stay there for long anyway :)