Hi, On Tue, 19 Mar 2019 00:24:08 +0100 Steven Mestdagh <ste...@openbsd.org> wrote:
> Charlene Wendling [2019-03-18, 14:57:23]: > > Hi ports, Steven, > > > > > http://build-failures.rhaalovely.net/sparc64/2019-02-03/graphics/pstoedit.log > > > http://build-failures.rhaalovely.net/powerpc/last/graphics/pstoedit.log > > > > It requires -std=c++11 once again, it builds fine on macppc after > > it's provided [1]. While here i've fixed a spacing inconsistency in > > COMPILER. > > > > I didn't bump REVISION, since pstoedit-3.73 has never been built on > > ports-gcc archs. > > > > Any comment? > > > > Charlène. > > > > [1] http://0x0.st/z8SZ.txt > > > sure, but -std=c++11 is also supported by clang, we could always > apply it? > If you're fine with this, so am i :) I've quickly grep'd the source code and it seems there is no c++14/17 feature that change could disable. Just to be sure, i've retested the build on macppc [1] and amd64 [2], without any issues. OK? Charlène. [1] http://0x0.st/z8pi.txt [2] http://0x0.st/z8p-.txt Index: Makefile =================================================================== RCS file: /cvs/ports/graphics/pstoedit/Makefile,v retrieving revision 1.27 diff -u -p -u -p -r1.27 Makefile --- Makefile 5 Jan 2019 10:08:33 -0000 1.27 +++ Makefile 19 Mar 2019 09:33:40 -0000 @@ -5,6 +5,7 @@ COMMENT= translate PostScript/PDF graphi DISTNAME= pstoedit-3.73 SHARED_LIBS= pstoedit 3.0 CATEGORIES= graphics +REVISION= 0 HOMEPAGE= http://www.pstoedit.net/ @@ -26,7 +27,11 @@ CONFIGURE_ARGS= --without-libplot \ --without-magick WANTLIB= c ${COMPILER_LIBCXX} m -COMPILER = base-clang ports-gcc base-gcc +# c++11 +COMPILER = base-clang ports-gcc base-gcc + +# This should be reviewed once moving to ports-gcc>=8 +CXXFLAGS += -std=c++11 post-install: ${INSTALL_MAN} ${WRKSRC}/doc/pstoedit.1 ${PREFIX}/man/man1
