On Wed, Mar 20 2019, Charlene Wendling <juliana...@posteo.jp> wrote: > Hi, > > On Wed, 20 Mar 2019 15:48:58 +0100 > Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote: > >> >> Hi, >> >> filezilla fails to build at least on powerpc and sparc64: >> >> http://build-failures.rhaalovely.net/powerpc/2019-02-04/net/filezilla.log >> http://build-failures.rhaalovely.net/sparc64/2019-03-04/net/filezilla.log >> >> --8<-- >> checking whether pugixml has been compiled with long long support... >> no configure: error: pugixml system library has been compiled without >> long long support >> -->8-- >> >> We have a local patch that prevents cmake from turning on long long >> (C++11) support. I guess the diff was needed to avoid a failure with >> cmake-3.1.x and/or base-gcc, back in 2015. >> >> If I remove our local patch, cmake-3.10.2 and ports-gcc happily build >> a library with long long support activated. base-clang builds aren't >> affected (long long support by default). > > Thanks a lot! > > I've tested on macppc, your diff solves the 'long long' issue at > filezilla's configure time (But the build fails later sadly, and i'm > building webkitgtk4 atm).
Yeah I suspected that but figured that the diff would still be an improvement. > By the way, HOMEPAGE should be moved to https. And HOMEPAGE says pugixml-1.9 has been released, so here's a diff for both. Not tested yet, if someone wants to pick it up: Index: Makefile =================================================================== RCS file: /cvs/ports/textproc/pugixml/Makefile,v retrieving revision 1.9 diff -u -p -r1.9 Makefile --- Makefile 21 Mar 2019 16:11:42 -0000 1.9 +++ Makefile 21 Mar 2019 16:29:58 -0000 @@ -2,15 +2,14 @@ COMMENT= light-weight, simple and fast XML parser for C++ -V= 1.7 +V= 1.9 DISTNAME= pugixml-$V -REVISION = 4 -SHARED_LIBS += pugixml 0.1 # 1.7 +SHARED_LIBS += pugixml 1.0 # 1.9 CATEGORIES= textproc devel -HOMEPAGE= http://pugixml.org/ +HOMEPAGE= https://pugixml.org/ MAINTAINER= Stuart Henderson <st...@openbsd.org> @@ -28,7 +27,5 @@ MODULES= devel/cmake CONFIGURE_ARGS+= -DBUILD_SHARED_LIBS=on NO_TEST= Yes - -WRKSRC= ${WRKDIST}/scripts .include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /cvs/ports/textproc/pugixml/distinfo,v retrieving revision 1.1.1.1 diff -u -p -r1.1.1.1 distinfo --- distinfo 30 Nov 2015 14:32:27 -0000 1.1.1.1 +++ distinfo 21 Mar 2019 16:29:58 -0000 @@ -1,2 +1,2 @@ -SHA256 (pugixml-1.7.tar.gz) = ++ENRvYddp99kqKWEC5OK9PuFhMPEcWxChquWQ6h9co= -SIZE (pugixml-1.7.tar.gz) = 354472 +SHA256 (pugixml-1.9.tar.gz) = 0VbTW4P2gOQP1kEsRFX90DVEM5d5E0YXubKNGeEf26Y= +SIZE (pugixml-1.9.tar.gz) = 377369 -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE