On 2019/03/22 16:05, Alessandro DE LAURENZIS wrote: > Hello Stuart, > > On 22/03/2019 15:16, Stuart Henderson wrote: > > [...] > > Diff on top of yours. > > > > - fix fetches > > > > - it's c++ so use COMPILER > > Just for my comprehension, could you please elaborate a bit (or point me to > the relevant manpage)?
On arches which still use GCC as the system compiler, a huge number of ports need to use the newer version of the compiler in ports, rather than the pre-c++11 one in base. Rather than playing whack-a-mole to fix breakage on those arches, and to avoid conflicts between the different C++ standard libraries for base and ports compilers, we're building everything using C++ with ports-gcc unless they're on the path to building ports-gcc itself. It's not ideal (especially because it's easily forgotten) but I don't have a better idea how to improve it yet.. > > > > - it builds with or without doxygen, but if present during the configure > > run then it's needed during build, so add a build dep > > > > - get rid of "-release @PACKAGE_VERSION@" to remove the lib symlink; > > if other things were looking for 'cudd-3.0.0' then you'd probably want > > to keep it but it doesn't sound like that's the case > > > > - symlink is simpler than patching for gdiff > > > > with this added, OK sthen@ to import. > [...] > > Works for me, no objections. Thanks a lot. > > -- > Alessandro DE LAURENZIS > [mailto:jus...@atlantide.t28.net] > Web: http://www.atlantide.t28.net > LinkedIn: https://www.linkedin.com/in/delaurenzis/ >
