On Sat, Apr 20, 2019 at 10:44:39PM -0400, Kurt Mosiejczuk wrote: > On Sat, Apr 20, 2019 at 10:39:28PM -0400, Daniel Jakots wrote: > > On Sat, 20 Apr 2019 19:22:07 -0700, Andrew Hewus Fresh > > <and...@afresh1.com> wrote: > > > > tl;dr, fixes portgen(1) for python modules that have distnames that > > > start with py-. > > > Thanks for working on that! > > > One suggestion, does a DISTNAME of "python-foo" is renamed to "py-foo" > > by portgen(1)?
I actually had a comment in the email suggesting that could be done fairly easily (and would be a straight-forward patch), but then deleted it as the email was already really long. I didn't even see that specific one because I was distracted by the ones that do: PKGNAME=${DISTNAME:S/python/py/} We also have a lot of places where we do this, but seems prone to error. PKGNAME=${DISTNAME:S/^py/py-/} and a few like this that I don't have enough python porting experience to know if we should do that if the DISTNAME has any uppercase in it. PKGNAME=py-${DISTNAME:L} > > The first result (as an example) in my grep is archivers/py-lzo: > > MODPY_EGG_VERSION = 1.08 > > DISTNAME = python-lzo-${MODPY_EGG_VERSION} > > PKGNAME = py-lzo-${MODPY_EGG_VERSION} > > > I haven't tested it but it would be great if it worked :) > > It doesn't. Not yet. You end up with py-python-foo. I tried with the > already existing python-dateutil and got py-python-dateutil. Dangit kurt, I'm trying to keep these patches focused :-D I can work up a patch tomorrow for S/^python-/py-/ l8rZ, -- andrew - http://afresh1.com Life's unfair - but root password helps!