On Thu, May 09, 2019 at 06:36:01AM +0000, wen heping wrote: > Hi, > > The new patch add openbsd tag in PLIST and add WANTLIB in Makefile. > > Comments?
p5-Ref-Util-XS could use TEST_DEPENDS=devel/p5-Readonly, as an XS module is not a candidate for PKG_ARCH=* so that needs to be removed, and the COMMENT should not start with a capital letter and could probably use a space before the open paren. For p5-Ref-Util, it also still needs the TEST_DEPENDS=devel/p5-Readonly and the COMMENT should not start with a capital letter. With that, OK afresh1@ > > wen > ________________________________ > 发件人: Charlene Wendling <juliana...@posteo.jp> > 发送时间: 2019年5月8日 17:05 > 收件人: wen heping > 抄送: ports@openbsd.org > 主题: Re: [NEW] devel/p5-Ref-Util and devel/p5-Ref-Util-XS (again) > > On Wed, 8 May 2019 00:58:25 +0000 > wen heping <wenheping2...@hotmail.com> wrote: > > > Hi: > > > > Here is a patch for create new port devel/p5-Ref-Util and > > devel/p5-Ref-Util-XS , both are needed by the future update of > > www/p5-Dancer2. It build and pass all the tests on my amd64 system on > > OpenBSD-current. > > > > I submitted it in March, this time I fix some bugs which pointed > > by afresh1@. > > As far as Ref::Util::XS is concerned, it's still the old version you're > sending, without Andrew's suggestions: > > https://marc.info/?l=openbsd-ports&m=155157380201369&w=2 > > Ref::Util would be happier with: > > TEST_DEPENDS= devel/p5-Readonly > > > OK? Comments ? > > > > Regards, > > wen > > Charlène. -- andrew - http://afresh1.com Computer Science: solving today's problems tomorrow.
