On Thu, Apr 25 2019, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote: > On Tue, Apr 23 2019, "Kent R. Spillner" <kspill...@acm.org> wrote: >> On Mon, Apr 08, 2019 at 10:40:50AM +0200, Jeremie Courreges-Anglas wrote: >>> On Wed, Apr 03 2019, "Kent R. Spillner" <kspill...@acm.org> wrote: >>> > On Tue, Apr 02, 2019 at 09:46:31PM -0400, Brian Callahan wrote: >>> >> Couple things: >>> >> 1. Patch applied with fuzz so re-run `make update-patches' >>> >> 2. When I ran `make update-plist' the PLIST got updated. >>> >> It added a 7z wrapper. So looks like either >>> >> archivers/p7zip has to be added to the deps or >>> >> --without-7z in the configure args. >>> >>> I don't think we should add a RUN_DEPENDS on p7zip. >>> >>> We *could* add a BUILD_DEPENDS to avoid the warning message and have the >>> compat symlink shipped by the package. But we have only one '7z' >>> executable in base + ports so the compat symlink doesn't help much. >>> >>> A RUN_DEPENDS on p7zip means 7MB of extra binaries for a rather limited >>> use case IMO. By following the same logic we would add archivers/bzip2, >>> archivers/xz, archivers/lzip etc to RUN_DEPENDS. >> >> Good point, I'll just disable 7z support. Ok? > > Thanks. Technically this doesn't remove 7z support, it just removes the > wrapper. > > I see that you're removing patches/patch-test_failbackup_test, but it > would be trivial to update instead, diff below. > > ok jca@
Hi Kent, is there any problem preventing to update to be committed? quilt-0.66 works fine for me. > Index: patches/patch-test_failbackup_test > =================================================================== > RCS file: /cvs/ports/devel/quilt/patches/patch-test_failbackup_test,v > retrieving revision 1.1 > diff -u -p -r1.1 patch-test_failbackup_test > --- patches/patch-test_failbackup_test 17 Nov 2017 14:59:18 -0000 > 1.1 > +++ patches/patch-test_failbackup_test 24 Apr 2019 18:44:41 -0000 > @@ -7,8 +7,8 @@ Index: test/failbackup.test > $ cat > test.txt > < This is updated test.txt. > $ quilt refresh --backup > -- >~ mv: cannot move [`']?%{P}test.diff'? to [`']?%{P}test.diff~'?: > Permission denied > -+ >~ mv: rename [`']?%{P}test.diff'? to [`']?%{P}test.diff~'?: Permission > denied > +- >~ mv: cannot move [`']?patches/test.diff'? to > [`']?patches/test.diff~'?: Permission denied > ++ >~ mv: rename [`']?patches/test.diff'? to [`']?patches/test.diff~'?: > Permission denied > $ echo %{?} > > 1 -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE