On Fri May 10, 2019 at 06:38:30PM -0400, Jeremie Courreges-Anglas wrote: > On Mon, Apr 15 2019, Rafael Sadowski <raf...@sizeofvoid.org> wrote: > > Please find below an update diff for TeXmacs 1.99.9. I stared to get rid > > of COMPILER=base-gcc. Upstream switched form Qt4 to Qt5 and from > > autotools to CMake. > > > > Build with base clang and runs without notable issues in > > a quick teston and64 . All regression tests are also passed. > > I got sick of this port needing base-gcc so I went ahead and fixed it to > build with ports-gcc. Now that base-gcc is out of the way, let's take > a look at your update. :) > > Here are some tweaks: > - missing COMPILER line, this is a C++ port
In our case this is always set by Qt5 module. > - no need to depend on git at build time Maybe we can set -DCMAKE_DISABLE_FIND_PACKAGE_Git=ON. I See some git calls: https://github.com/texmacs/texmacs/blob/0b437b9fa0ec2960c0c9b0c84ecac0028d27c1d6/3rdparty/benchmark/cmake/GetGitVersion.cmake https://github.com/texmacs/texmacs/blob/0b437b9fa0ec2960c0c9b0c84ecac0028d27c1d6/3rdparty/benchmark/CMakeLists.txt > - add libexecinfo to LIB_DEPENDS, since you explicitely link against it Yes please > - sync WANTLIB (png16 -> png) > - add -Wno-deprecated-register to cut down the noise in build logs > - drop patches/patch-src_System_Link_pipe_link_cpp, not relevant any more >
