On 2019/05/13 21:13, Giovanni Bechis wrote: > On Mon, May 13, 2019 at 12:24:29PM +0100, Stuart Henderson wrote: > > On 2019/05/13 12:23, Stuart Henderson wrote: > > > On 2019/05/13 09:02, Giovanni Bechis wrote: > > > > On 5/13/19 8:42 AM, David CARLIER wrote: > > > > > If you mention testapp executable it does not coredump. No worries if > > > > > you wanna keep the no_drop_privileges patch tho. > > > > > Regards. > > > > > > > > > > On Mon, 13 May 2019 at 07:32, Giovanni Bechis <giova...@paclan.it> > > > > > wrote: > > > > >> > > > > >> On Sun, May 12, 2019 at 01:08:51PM +0100, David CARLIER wrote: > > > > >>> Hi, > > > > >>> > > > > >>> Here a proposal straight to 1.5.14, removing a patch due to > > > > >>> drop_privilege support feature. > > > > >>> > > > > >> why you removed that patch ? I think in OpenBSD dropping privileges > > > > >> should be > > > > >> mandatory. > > > > >> Does it pass regression tests (at least the same tests that passes > > > > >> with 1.5.6) ? > > > > >> I have a 1.5.12 port on my tree that core dumps during regression > > > > >> tests, I haven't > > > > >> checked 1.5.14 yet. > > > > >> Giovanni > > > > > > > > > New diff attached, I will commit it in a few days. > > > > > > Maybe worth adding --enable-tls (and syncing WANTLIB)? > > > > > > OK either way. > > > > > > > Oh actually... hold for a little while, I want to make sure it still builds > > on arm64. > > > I do not know if it's useful or not, there is a "--enable-arm-crc32 (ARMv8 > CRC32 instructions)" > option as well in configure. > Giovanni >
Yep that is why I wanted to check, in case it autodetected it and triggered breakage there. Confirmed it builds, so I am OK to go ahead (either with or without --enable-tls).
