On 2019/06/16 17:39, Thomas Frohwein wrote:
> Hi,
> 
> OpenRA dlopen's libraries via the mono-config(5) dllmap mechanism. It
> seems that if openal, freetype, and SDL2 are not listed as WANTLIB they
> are not installed as RUN_DEPENDS (this is how I read bsd.port.mk(5)).
> The diff below adds these libraries to WANTLIB and this way I can't
> install the package if openal is not present. Same should go for SDL2
> and freetype.
> 
> The missing installation of openal for runtime was reported by Matthias
> (@_xhr_@mastodon.social).
> 
> ok?
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/games/openra/Makefile,v
> retrieving revision 1.3
> diff -u -p -r1.3 Makefile
> --- Makefile  28 Apr 2019 03:34:16 -0000      1.3
> +++ Makefile  16 Jun 2019 23:30:45 -0000
> @@ -6,7 +6,7 @@ DISTNAME =            openra-${V}
>  CATEGORIES =         games x11
>  HOMEPAGE =           https://www.openra.net
>  MAINTAINER =         Thomas Frohwein <t...@openbsd.org>
> -REVISION =           1
> +REVISION =           2
>  
>  # GPLv3 (openra)
>  # MIT (StyleCopPlus, StyleCop, SharpZipLib, NUnit, NUnit.Console, Open.Nat,
> @@ -15,6 +15,9 @@ REVISION =          1
>  # GPLv2 (FuzzyLogicLibrary)
>  # zlib (SDL2-CS, OpenAL-CS)
>  PERMIT_PACKAGE_CDROM =       Yes
> +
> +# dlopen'd via mono-config(5)
> +WANTLIB +=   SDL2 freetype openal
>  
>  MASTER_SITES =       https://mirrors.nycbug.org/pub/distfiles/
>  EXTRACT_SUFX =               .tar.xz
> 

OK sthen@.

You have two options, either as you've done (i.e. LIB_DEPENDS + WANTLIB +
explanatory comment - which I prefer), or just list them in RUN_DEPENDS.

The "tell" for this is the "LIB_DEPENDS <spec> not needed for <FULLPKGPATH>"
message when building the package.

Reply via email to