On Sat, Jun 29 2019, Kurt Mosiejczuk <k...@cranky.work> wrote:
> On Sat, Jun 29, 2019 at 10:31:52PM -0400, Daniel Jakots wrote:
>> On Sat, 29 Jun 2019 21:41:50 -0400, Kurt Mosiejczuk <k...@cranky.work>
>> wrote:
>
>> > Also, do you wish to have the package named recommonmark-0.5.0 or
>> > py-recommonmark-0.5.0? Right now it is the former since there isn't a
>> > PKGNAME line. 
>
>> Since Jeremie chose to have a flavor, it needs to be py- prefixed.
>
> Good point.

Duh, indeed.

>> Also, setting MODPY_EGG_VERSION is useless or I'm missing something?
>
> It's not necessary if using the GH_* tags, but if there is intention to
> move it to PyPI in the future, it makes sense.

The package started as a MODPY_PI port, but I indeed decided to go for
the github repo to get more tests to run.  It's not perfect yet, as I'm
not sure I understand the cause for the "KeyError: 'refdoc'" tracebacks.

Updated tarball attached, diff below.  Thanks for your help.

--8<--
diff -pruN py-recommonmark.old/Makefile py-recommonmark/Makefile
--- py-recommonmark.old/Makefile        Sat Jun 29 07:24:49 2019
+++ py-recommonmark/Makefile    Sun Jun 30 12:21:24 2019
@@ -2,10 +2,13 @@
 
 COMMENT =              markdown parser for docutils
 
-MODPY_EGG_VERSION =    0.5.0
+MODPY_EGG_VERSION =    0.5.0
+# Using github autogenerated tarball because pypi tarballs don't ship
+# files needed by tests.
 GH_ACCOUNT =           readthedocs
 GH_PROJECT =           recommonmark
 GH_TAGNAME =           ${MODPY_EGG_VERSION}
+PKGNAME =              py-recommonmark-${MODPY_EGG_VERSION}
 
 CATEGORIES =           textproc devel
 
@@ -20,7 +23,6 @@ MODPY_SETUPTOOLS =    Yes
 RUN_DEPENDS =          textproc/py-commonmark${MODPY_FLAVOR} \
                        textproc/py-docutils${MODPY_FLAVOR} \
                        textproc/py-sphinx${MODPY_FLAVOR}
-TEST_DEPENDS =         ${RUN_DEPENDS}
 
 FLAVORS =              python3
 FLAVOR ?=
-->8--


Attachment: py-recommonmark.2.tgz
Description: Binary data

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to