On 2019/07/11 23:12, Christian Weisgerber wrote: > A few words about cleaning up PERMIT_PACKAGE_*, since I've done > similar changes before. > > You might think this will take care of itself over time, as ports > are updated and modified, they'll eventually all get cleaned up. > Past experience suggests that this won't happen or will take a very > long time. A subset of ports is touched frequently, but there is > a long tail that sees no changes from one release to the next. So, > yeah, eventually we'll need to sit down and do an explicit cleanup > run. > > You want to do this in steps and eliminate the obsolete settings from > (1) modules and the ports that use them; > (2) all instances of Makefile.inc and the ports that use them; > (3) multi-package ports; > (4) the rest, which is simple now. > > There are no modules that set PERMIT_PACKAGE_*, so that's it for > step (1). > > If you want to move this forward, (2) is where we're at now. > There are 100+ Makefile.inc files that set PERMIT_PACKAGE_*. > > Step (4) is very amenable to scripting. There's really no point > in manually changing simple ports when they can be covered by a > script run, and it doesn't matter whether a thousand or five thousand > are left.
What do you think about starting from the other side, moving all the files (modules, ports, Makefile.inc) which just have a single ^PERMIT_PACKAGE_.* line which is PERMIT_PACKAGE_CDROM=Yes to PERMIT_PACKAGE=Yes? Then it's easier to spot the remaining oddities and work through them.
