On Wed, Jul 17, 2019 at 12:50:34AM -0400, Kurt Mosiejczuk wrote:
> On Thu, Jun 27, 2019 at 03:14:31PM +0200, Martin Reindl wrote:
>
> > Here are the two updated tarballs with the ports. py-netcdf4 got a
> > mini-update to 1.5.1.2 in the meantime.
>
> I got back to these two ports.
>
> For py-cftime, I ended u padding a bunch of TEST_DEPENDS including
> adding py-ipaddress for the python2 flavor. I added the package itself
> to the TEST_DEPENDS. With that it passed all tests for python2 and
> all but one for python3 on both amd64 and sparc64. I also tweaked the
> do-test target so it set all environment variables it should.
>
> For py-netcdf4 I tweaked the PKGNAME to be all lowercase. All of its
> similarly named dependencies stay lowercase. I added itself to the
> TEST_DEPENDS. I added TEST_ENV with TMPDIR pointing at ${WRKDIR}/tmp
> since it wants to slap a 4 gigabyte test file in /tmp and my /tmp
> partition is not good enough. I added a pre-test to create the tmp
> directory in ${WRKDIR}. I also tweaked the do-test target just like I
> did for py-cftime. All tests pass on amd64. Well, all pass
> if it has network. A handful of them fail if doing PORTS_PRIVSEP. (I
> temporarily allowed _pbuild network for a second attempt at the tests).
>
> On sparc64, py-netcdf4 fails two tests: test_unsigned and VariablesTestCase.
>
> ======================================================================
>
> FAIL: test_unsigned (tst_Unsigned.Test_Unsigned)
>
> ----------------------------------------------------------------------
>
> Traceback (most recent call last):
> File
> "/usr/ports/pobj/py-netcdf4-1.5.1.2-python3/netCDF4-1.5.1.2/test/tst_Unsi
> gned.py", line 31, in test_unsigned
> assert(data1.mask.sum() == data2.mask.sum())
> AssertionError
>
> ======================================================================
> FAIL: runTest (tst_compoundvar.VariablesTestCase)
> testing compound variables
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/usr/ports/pobj/py-netcdf4-1.5.1.2-python3/netCDF4-1.5.1.2/test/tst_comp
> oundvar.py", line 72, in setUp
> assert (cmptype4 == dtype4a) # data type should be aligned
> AssertionError
>
> I don't know if it is their test code or some other difference on sparc64.
>
Very grateful for your thorough testing and input for these ports.
>From a first glance this is a netcdf-specific code problem on sparc64. dtype4a
is numpy code where I suspect there is no problem on sparc64. Whereas cmdtype4
uses netcdf's createCompoundType method. Need to look deeper into this as time
permits, even though I am not getting a sparc64 (again).
-m
