On Wed, Jul 17, 2019 at 02:13:20PM -0400, Daniel Jakots wrote:
> On Wed, 17 Jul 2019 11:06:41 -0600, Todd C. Miller
> <mill...@openbsd.org> wrote:
> 
> > [Now with the attachment...]
> > 
> > I'm working on a port for isso (https://github.com/posativ/isso)
> > and one of its depencencies is misaka, a CFFI-based binding for
> > Hoedown, a fast markdown processing library written in C.  It
> > features a fast HTML renderer and functionality to make custom
> > renderers (e.g. man pages or LaTeX).  Misaka comes with an embedded
> > copy of hoedown (which is often how hoedown is used).
> > 
> > It's been a while since I've done a new port and my python skills
> > are a bit rough.  However, misaka passes all its tests so I have
> > some confidence that it works.
> > 
> >  - todd
> 
> 3 points from a quick glance at the files:
> 
> From the porting guide [1]: 
> 
> > Do NOT start with an uppercase letter unless semantically
> > significant, and do NOT end with a period. DON'T EVER START WITH AN
> > INDEFINITE ARTICLE SUCH AS "a" or "an" - remove the article
> > altogether.
> 
> The port provides a "binary", you need to rename it otherwise the py2
> and py3 versions conflict. You can take the www/py-gunicorn's
> post-install target as it's generic and it will just work.
> 
> The PLIST has a .so, I guess it means you will need a WANTLIB line.
> make lib-depends-check will confirm if you need it.
> 
> [1] https://www.openbsd.org/faq/ports/guide.html point 16

Also, you're mixing variables with and without space before of the equal
sign.

*_DEPENDS are using spaces for indentation.


-- 
Juan Francisco Cantero Hurtado http://juanfra.info

Reply via email to