Looks good for me. Ok pea@ Thank you
Le 24 août 2019 22:54:41 GMT+02:00, Stuart Henderson <s...@spacehopper.org> a écrit : >On 2019/08/18 08:51, Antoine Jacoutot wrote: >> On Sat, Aug 17, 2019 at 10:55:11PM +0200, Adam Wolk wrote: >> > Hi ports@, >> > >> > I'm attaching a small diff to allow picking a different postgresql >> > cluster (the directory you create with initdb) location within >> > /etc/rc.conf.local. >> > >> > With the attached diff, one can now define the folder with: >> > postgresql_flags="-D /var/postgresql/testdata -w -l >> > /var/postgresql/logfile" >[..snip..] > >> > >> > I also noticed that the postgresql_flags line is used verbatim in >the >> > ENVIRONMENT section of rc.d(8), should I update that manual to >include >> > the -D that is now the new default for flags? I assume that yes, so >the >> > third diff covers that, however the extended line wraps in the >manual >> > now (perhaps that is undesired?). >> > >> > As always I'm looking for feedback and OK's :) >> >> I like this. > >me too. > >> > I do think that this could warrant an entry in current.html. > >yes, I agree. > >OK with all except one part, > >> > Index: rc.d.8 >> > =================================================================== >> > RCS file: /cvs/src/share/man/man8/rc.d.8,v >> > retrieving revision 1.34 >> > diff -u -p -r1.34 rc.d.8 >> > --- rc.d.8 27 Jul 2017 07:49:05 -0000 1.34 >> > +++ rc.d.8 17 Aug 2019 20:21:28 -0000 >> > @@ -137,13 +137,13 @@ with the name of the script. >> > For example, postgres is managed through >> > .Pa /etc/rc.d/postgresql : >> > .Pp >> > -.Dl daemon_flags=-w -l /var/postgresql/logfile >> > +.Dl daemon_flags="-D /var/postgresql/data -w -l >/var/postgresql/logfile" >> > .Pp >> > To override this and increase the debug log level (keeping the >existing >> > flags), define the following in >> > .Xr rc.conf.local 8 : >> > .Pp >> > -.Dl postgresql_flags=-w -l /var/postgresql/logfile -d 5 >> > +.Dl postgresql_flags="-D /var/postgresql/data -w -l >/var/postgresql/logfile -d 5" > >I think this should be without quotes, it works either way but the >normal documented format is without, e.g. see the dhcpd_flags example >in rc.conf.local(5). > >> > .Pp >> > Each script may define its own defaults, as explained in >> > .Xr rc.subr 8 .
