Hi,
> http://build-failures.rhaalovely.net/powerpc/2019-08-30/x11/grantlee-qt5.log
> http://build-failures.rhaalovely.net/sparc64/2019-09-08/x11/grantlee-qt5.log
There is some funny stuff going on here. On base-gcc archs,
grantlee-qt5 is built with c++98, while it requires at least c++11.
eg++(1) manpage:
-ansi
In C mode, this is equivalent to -std=c90. In C++ mode, it is
equivalent to -std=c++98.
clang++(1) manpage:
-ansi Same as -std=c89.
Removing '-ansi' is solving the issue on macppc [0], while keeping
amd64 fine.
Comments/feedback are welcome!
Charlène.
[0] https://bin.charlenew.xyz/grantlee-qt5-5.1.0p2.log
Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/grantlee-qt5/Makefile,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 Makefile
--- Makefile 12 Jul 2019 20:51:12 -0000 1.4
+++ Makefile 19 Sep 2019 16:22:26 -0000
@@ -5,7 +5,7 @@ COMMENT = template and text document li
VERSION = 5.1.0
PKGNAME = grantlee-qt5-${VERSION}
DISTNAME = grantlee-${VERSION}
-REVISION = 1
+REVISION = 2
SHARED_LIBS += Grantlee_Templates 0.0 # 5.1
SHARED_LIBS += Grantlee_TextDocument 0.0 # 5.1
Index: patches/patch-CMakeLists_txt
===================================================================
RCS file: /cvs/ports/x11/grantlee-qt5/patches/patch-CMakeLists_txt,v
retrieving revision 1.2
diff -u -p -u -p -r1.2 patch-CMakeLists_txt
--- patches/patch-CMakeLists_txt 14 Aug 2018 05:23:08 -0000 1.2
+++ patches/patch-CMakeLists_txt 19 Sep 2019 16:22:26 -0000
@@ -1,4 +1,6 @@
$OpenBSD: patch-CMakeLists_txt,v 1.2 2018/08/14 05:23:08 rsadowski Exp $
+Hunk #2: ports-gcc fix because with it, -ansi means -std=c++98, and
+grantlee wants c++11
Index: CMakeLists.txt
--- CMakeLists.txt.orig
@@ -20,6 +22,15 @@ Index: CMakeLists.txt
set(CMAKE_CXX_FLAGS_COVERAGE "${CMAKE_CXX_FLAGS_RELEASE} -fprofile-arcs
-ftest-coverage")
set(CMAKE_C_FLAGS_COVERAGE "${CMAKE_C_FLAGS_RELEASE} -fprofile-arcs
-ftest-coverage")
set(CMAKE_SHARED_LINKER_FLAGS_COVERAGE
"${CMAKE_SHARED_LINKER_FLAGS_RELEASE} -fprofile-arcs -ftest-coverage")
+@@ -56,7 +56,7 @@ endif()
+
+ if (CMAKE_COMPILER_IS_GNUCXX)
+ set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-long-long -std=iso9899:1990
-Wundef -Wcast-align -Werror-implicit-function-declaration -Wchar-subscripts
-Wall -W -Wpointer-arith -Wwrite-strings -Wformat-security
-Wmissing-format-attribute -fno-common")
+- set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wnon-virtual-dtor -Wno-long-long
-ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith
-Wformat-security -fno-check-new -fno-common ")
++ set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wnon-virtual-dtor -Wno-long-long
-Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith
-Wformat-security -fno-check-new -fno-common ")
+
+ if (CMAKE_BUILD_TYPE MATCHES TestCocoon)
+ # Needed on 64 bit
@@ -100,7 +100,7 @@ set (LIB_SUFFIX "" CACHE STRING "Define suffix of libr
set( LIB_INSTALL_DIR lib${LIB_SUFFIX} )
set( PLUGIN_INSTALL_DIR
${LIB_INSTALL_DIR}/grantlee/${Grantlee5_MAJOR_MINOR_VERSION_STRING} )
