On Fri, 20 Sep 2019 at 11:44:58 -0500, joshua stein wrote:
> On Fri, 20 Sep 2019 at 17:33:40 +0100, Stuart Henderson wrote:
> > On 2019/09/20 10:00, joshua stein wrote:
> > > While the Chrome port uses separate files in /etc/chromium for
> > > unveil file lists, these patches use new comma-separated
> > > about:config keys for them.
> >
> > > onts r,/etc/machine-id r,/etc/mailcap r,/tmp rwc,/usr/bin/lpr
> > > rx,/usr/local=
> > > /bin/gio-launch-desktop rx,/usr/local/lib r,/usr/local/firefox
> > > r,/usr/local=
> > > /lib/firefox rx,/usr/local/share r,/usr/share/locale
> > > r,/var/cache/fontconfi=
> > > g r,/usr/X11R6/lib r,/usr/X11R6/share r,/var/run rw,~/.XCompose
> > > r,~/.Xautho=
> >
> > Ports shouldn't use hardcoded /usr/local - the diff attached uses
> > ${LOCALBASE}/${TRUEPREFIX} instead of /usr/local as appropriate,
> > ${X11BASE} instead of /usr/X11R6, ${SYSCONFDIR} for the /etc files
> > that comes from ports rather than base, and ${SUBST_CMD} in
> > post-patch to substitute them for the correct paths.
>
> These patches have to go upstream, so those paths can't be dynamic.
> I don't know what Landry's plan is for patching our port before they
> are committed upstream, but once they are committed, I guess there
> can be a post-patch step to turn them from hard-coded defaults to
> ${LOCALBASE} and friends.
Or I guess at that point it would actually be a patch to the
hard-coded files, which then has to get post-patched. I don't know.
But to clarify, I'm not proposing to commit what I'm sending out,
this is just to get feedback from Firefox users so I can refine the
changes that are going upstream. Then once they are committed or at
least slated for inclusion, we can figure out how to integrate them
into our port(s) and patch up any hard-coded paths.
