On Mon, Aug 26, 2019 at 03:26:49AM +0000, wen heping wrote:
> Here is the revised patch:
>
> i) Remove BUILD_DEPENDS
> ii) Add p5-Test-Exception as TEST_DEPENDS, else
> t/200-import-check.t would be skipped.
OK afresh1@
> wen
> ________________________________
> 发件人: Andrew Hewus Fresh <and...@afresh1.com>
> 发送时间: 2019年8月26日 7:47
> 收件人: wen heping <wenheping2...@hotmail.com>
> 抄送: c...@openbsd.org <c...@openbsd.org>; ports@openbsd.org <ports@openbsd.org>
> 主题: Re: [Update] devel/p5-Test-Compile : Update to 2.2.2
>
> On Fri, Jul 26, 2019 at 09:23:21AM +0000, wen heping wrote:
> > Hi,
> >
> > Here is a patch for devel/p5-Test-Compile:
> > i) Update to 2.2.2
> > ii) Add devel/p5-Test-HasVersion as TEST_DEPENDS.
> >
> > It build well and passed all tests on amd64-head system.
> >
> > Three ports depends on p5-Test-Compile:
> > 1) devel/p5-FileHandle-Unget
> > 2) devel/p5-Getargs-Long
> > 3) mail/p5-Mail-Mbox-MessageParser
> > All build well and passed all tests on amd64-head system with this
> > patch.
> >
> > Comments? OK?
> >
> > wen
>
> I don't think it actually needs the BUILD_DEPENDS in order to package
> properly,
>
> We do have the optional devel/p5-Test-Exception to add to TEST_DEPENDS.
>
> With that, OK afresh1@
>
>
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/devel/p5-Test-Compile/Makefile,v
> > retrieving revision 1.2
> > diff -u -p -r1.2 Makefile
> > --- Makefile 12 Jul 2019 20:45:09 -0000 1.2
> > +++ Makefile 26 Jul 2019 09:15:40 -0000
> > @@ -1,7 +1,7 @@
> > # $OpenBSD: Makefile,v 1.2 2019/07/12 20:45:09 sthen Exp $
> >
> > COMMENT = check whether Perl files compile correctly
> > -DISTNAME = Test-Compile-v1.3.0
> > +DISTNAME = Test-Compile-v2.2.2
> > PKGNAME = p5-${DISTNAME:S/v//g}
> > CATEGORIES = devel
> >
> > @@ -17,6 +17,7 @@ RUN_DEPENDS = devel/p5-Universal-requir
> > devel/p5-Devel-CheckOS
> > BUILD_DEPENDS = ${RUN_DEPENDS}
> > TEST_DEPENDS = devel/p5-Perl-Critic \
> > + devel/p5-Test-HasVersion \
> > devel/p5-Test-Perl-Critic \
> > devel/p5-Test-Portability-Files \
> > devel/p5-Test-Warnings
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/devel/p5-Test-Compile/distinfo,v
> > retrieving revision 1.1.1.1
> > diff -u -p -r1.1.1.1 distinfo
> > --- distinfo 13 Jan 2019 14:50:03 -0000 1.1.1.1
> > +++ distinfo 26 Jul 2019 09:15:40 -0000
> > @@ -1,2 +1,2 @@
> > -SHA256 (Test-Compile-v1.3.0.tar.gz) =
> > d1J+lHesUmBEPHVjZ6f3vD2PbG67xWGwsvs/eTA7rTM=
> > -SIZE (Test-Compile-v1.3.0.tar.gz) = 15198
> > +SHA256 (Test-Compile-v2.2.2.tar.gz) =
> > eFO0SpgZ6z5gAyYO7fkEoa2AA16lJUKWzgFPlghLZdQ=
> > +SIZE (Test-Compile-v2.2.2.tar.gz) = 17532
>
>
> --
> andrew - http://afresh1.com
>
> "Programming today is a race between software engineers striving to
> build bigger and better idiot-proof programs, and the Universe
> trying to produce bigger and better idiots. So far, the Universe is
> winning." -- Rich Cook
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/p5-Test-Compile/Makefile,v
> retrieving revision 1.2
> diff -u -p -r1.2 Makefile
> --- Makefile 12 Jul 2019 20:45:09 -0000 1.2
> +++ Makefile 26 Aug 2019 03:23:04 -0000
> @@ -1,7 +1,7 @@
> # $OpenBSD: Makefile,v 1.2 2019/07/12 20:45:09 sthen Exp $
>
> COMMENT = check whether Perl files compile correctly
> -DISTNAME = Test-Compile-v1.3.0
> +DISTNAME = Test-Compile-v2.2.2
> PKGNAME = p5-${DISTNAME:S/v//g}
> CATEGORIES = devel
>
> @@ -15,8 +15,9 @@ PKG_ARCH = *
>
> RUN_DEPENDS = devel/p5-Universal-require \
> devel/p5-Devel-CheckOS
> -BUILD_DEPENDS = ${RUN_DEPENDS}
> TEST_DEPENDS = devel/p5-Perl-Critic \
> + devel/p5-Test-Exception \
> + devel/p5-Test-HasVersion \
> devel/p5-Test-Perl-Critic \
> devel/p5-Test-Portability-Files \
> devel/p5-Test-Warnings
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/devel/p5-Test-Compile/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo 13 Jan 2019 14:50:03 -0000 1.1.1.1
> +++ distinfo 26 Aug 2019 03:23:04 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (Test-Compile-v1.3.0.tar.gz) =
> d1J+lHesUmBEPHVjZ6f3vD2PbG67xWGwsvs/eTA7rTM=
> -SIZE (Test-Compile-v1.3.0.tar.gz) = 15198
> +SHA256 (Test-Compile-v2.2.2.tar.gz) =
> eFO0SpgZ6z5gAyYO7fkEoa2AA16lJUKWzgFPlghLZdQ=
> +SIZE (Test-Compile-v2.2.2.tar.gz) = 17532
--
andrew - http://afresh1.com
The 3 great virtues of a programmer: Laziness, Impatience, and Hubris.
--Larry Wall
