On 2019/09/25 10:10, clematis wrote: > On Sun, Sep 22, 2019 at 08:43:04PM +0200, Rafael Sadowski wrote: > > - My $COMMENT suggestion: "Python interface to the Bitcoin data > > structures and protocol" > > - Looks like this is only py3: " Python3 library providing an easy > > interface to the Bitcoin data structures and protocol." from the git > > repo. The port is py2 with a py3 FLAVOR.
The 0.10.2 release is py2/3 (the README says "This Python2/3 library provides an easy interface to the bitcoin data structures and protocol"), but python 2 support was removed in https://github.com/petertodd/python-bitcoinlib/commit/de971091b I agree with just adding the py3 version, since py2 support is clearly going away in a forthcoming release. > > - I prefer just "This Python3 library provides an easy interface to the > > bitcoin data structures and protocol." in DESCR. The additional text > > is not helpful. > > > > Otherwise, it works for me. > Hi Rafael, > > Thanks for your feedback, appreciated. So based on this I made the > changes below: > - update COMMENT > - update DESCR > - remove FLAVOR and default to py3 > - change PKGNAME so it gets the py3- > - add MAINTAINER > > All of the 142 regressions tests still complete successfully. > > New tarball attached. > > Comments? OK? > > Thanks. > -- > clematis (0x7e96fd2400fe7b59) Please put COMMENT onto one line rather than \ continuation. Otherwise ok with me.
