On Tue, Nov 12, 2019 at 11:22:31AM +0100, Charlene Wendling wrote:
> Hi,
>
> > http://build-failures.rhaalovely.net/sparc64/2019-11-08/productivity/gnucash.log
> (guile2 is still BROKEN on powerpc, so i can't test)
>
> This is happening since the glib2 update. G_INLINE_FUNC is
> deprecated [0], and should be replaced by `static inline'. I preferred
> to not patch the code because i expect upstream to change it in our
> stead in a future update anyway.
>
> GNUcash has still -Werror in CFLAGS, it should build if disabled,
> like it used to. I've bumped REVISION "by the book" but afaik
> `-Werror' has no impact on the binaries produced.
>
> As i can't test it, i hope someone will do it on sparc64 ;)
>
> Charlène.
>
>
> [0]
> https://developer.gnome.org/glib/stable/glib-Miscellaneous-Macros.html#G-INLINE-FUNC:CAPS
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/productivity/gnucash/Makefile,v
> retrieving revision 1.116
> diff -u -p -u -p -r1.116 Makefile
> --- Makefile 26 Sep 2019 10:22:41 -0000 1.116
> +++ Makefile 12 Nov 2019 10:07:21 -0000
> @@ -5,7 +5,7 @@ COMMENT = personal and small-business f
> GNOME_PROJECT = gnucash
> GNOME_VERSION = 3.7
> EXTRACT_SUFX = .tar.bz2
> -REVISION = 0
> +REVISION = 1
That's not needed.
>
> DISTFILES = ${DISTNAME}${EXTRACT_SUFX} \
> gnucash-docs-${GNOME_VERSION}.tar.gz
> @@ -71,6 +71,8 @@ CONFIGURE_ENV += "CXX=${CXX} -I${LOCALBA
>
> # XXX not picked up from config.h
> CFLAGS += -DHAVE_SCANF_LLD
> +# XXX G_INLINE_FUNC is deprecated, fix the build with ports-gcc
> +CFLAGS += -Wno-error
>
> CXXFLAGS += -Wno-error
>
>
--
Antoine
