On 2019/11/21 10:24, Edd Barrett wrote: > setuptools tries to download this dependency if it's not installed, and > presumably that only showed under dpb, where there's a pf rule to block > network access.
It shows up outside of DPB as well, if you have PORTS_PRIVSEP=Yes in mk.conf and the default PF rules. (I didn't spot it because test-runner was already installed on my system). > Obvious fix: add devel/py-test-runner as a BUILD_DEPEND. > > However, as far as I can see, pytest-runner isn't used. If you comment > out the dependency, the build works fine, and the tests also don't seem > to require it. > > So this change removes the dependency. Also an unrelated patch churned > from `make update-patches` -- should have done that in the update > yesterday. > > No bumps needed, I think. > > OK? OK. (It could probably be converted to MODPY_PYTEST as well) > > Index: patches/patch-setup_py > =================================================================== > RCS file: patches/patch-setup_py > diff -N patches/patch-setup_py > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-setup_py 21 Nov 2019 10:14:46 -0000 > @@ -0,0 +1,19 @@ > +$OpenBSD$ > + > +pytest-runner isn't actually required: > +https://github.com/neovim/pynvim/issues/417 > + > +Index: setup.py > +--- setup.py.orig > ++++ setup.py > +@@ -8,9 +8,7 @@ install_requires = [ > + 'msgpack>=0.5.0', > + ] > + > +-setup_requires = [ > +- 'pytest-runner' > +-] > ++setup_requires = [] > + > + tests_require = [ > + 'pytest>=3.4.0', > Index: patches/patch-test_conftest_py > =================================================================== > RCS file: /cvs/ports/editors/py-neovim/patches/patch-test_conftest_py,v > retrieving revision 1.2 > diff -u -p -r1.2 patch-test_conftest_py > --- patches/patch-test_conftest_py 17 Mar 2019 13:15:34 -0000 1.2 > +++ patches/patch-test_conftest_py 21 Nov 2019 10:07:38 -0000 > @@ -8,9 +8,9 @@ version. > Index: test/conftest.py > --- test/conftest.py.orig > +++ test/conftest.py > -@@ -0,0 +1,67 @@ > -+import json > -+import os > +@@ -1,5 +1,72 @@ > + import json > + import os > +import textwrap > + > +import pynvim > @@ -76,3 +76,8 @@ Index: test/conftest.py > + editor = pynvim.attach('socket', path=listen_address) > + > + return editor > ++import json > ++import os > + > + import pytest > + > > -- > Best Regards > Edd Barrett > > http://www.theunixzoo.co.uk >
