пт, 13 дек. 2019 г. в 22:17, Brad DeMorrow <[email protected]>:
>
> I wasn't clear, thorough, and concise in my previous email.  My apologies.
>
> These three ports are required to enable VA-API support in OpenBSD.

Cool. At some point in the past I worked on those, but stopped due to
the same problem as seen with yours port, see below.

> What has changed?: Nothing, these are new ports.
> Architectures tested on: amd64
> Impact on consumers: No consumers yet.
> Requirements for testing: An inteldrm device.

It looks like not all inteldrm will work. At least mine (found on
ThinkPad X240) doesn't:

$ vainfo
libva info: VA-API version 1.6.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /usr/local/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_1_6
libva error: /usr/local/lib/dri/i965_drv_video.so init failed
libva info: va_openDriver() returns -1
vaInitialize failed with error code -1 (unknown libva error),exit

Here's an excerpt from pcidump -v:

 0:2:0: Intel HD Graphics
        0x0000: Vendor ID: 8086, Product ID: 0a16
        0x0004: Command: 0007, Status: 0090
        0x0008: Class: 03 Display, Subclass: 00 VGA,
                Interface: 00, Revision: 0b
        0x000c: BIST: 00, Header Type: 00, Latency Timer: 00,
                Cache Line Size: 00
        0x0010: BAR mem 64bit addr: 0x00000000e0000000/0x00400000
        0x0018: BAR mem prefetchable 64bit addr: 0x00000000c0000000/0x20000000
        0x0020: BAR io addr: 0x00003000/0x0040
        0x0024: BAR empty (00000000)
        0x0028: Cardbus CIS: 00000000
        0x002c: Subsystem Vendor ID: 17aa Product ID: 2214
        0x0030: Expansion ROM Base Address: 00000000
        0x0038: 00000000
        0x003c: Interrupt Pin: 01 Line: 0b Min Gnt: 00 Max Lat: 00
        0x0090: Capability 0x05: Message Signalled Interrupts (MSI)
                Enabled: yes
        0x00d0: Capability 0x01: Power Management
                State: D0
        0x00a4: Capability 0x13: PCI Advanced Features

All those Intel graphics names are voodoo for me still, so don't
expect me helping to narrow supported hardware list. :-(

> Testing Instructions:
> 1. Install libva first.
> 2. Install intel-vaapi-driver second.
> 3. Install libva-utils last.
> 4. Run vainfo.  If it succeeds, it will list several lines for supported
> Profiles on your machine.
> 5. libva-utils is also their test repository for va-api.  Run a make test
> for the libva-utils port.
>
> Notes:
> There are 17415 unit tests for VA-API contained within the libva-utils
> port.  I've enabled
> them and they all pass on amd64. portcheck and port-lib-depends-check
> succeeds on all
> three ports.
>
> If we get this in, it's my understanding that many other ports could
> benefit from it, such as
> ffmpeg and chromium.
>
> Thank you all for your time.

Some issues:

Please make ports look like closer to Makefile.template: indentation
etc. In particular,  don't wrap WANTLIB lines, this just wastes space.

Tests in libva-utils are hardware-dependant. I think it's better to
mark them with TEST_IS_INTERACTIVE=Yes, adding descriptive comment
above.

Why are you using meson? The autotools will work better in this case,
at least you'll have SHARED_LIBS stuff right. See the tweaked libva
port Makefile for example.

Please regen PLIST for intel-vaapi-driver port, this should add @so marker.

Do not say "Foo is a bar" in COMMENT for foo-1.0 package, just put
"bar" there, that's enough.

-- 
  WBR,
  Vadim Zhukov

Attachment: Makefile.libva
Description: Binary data

Reply via email to