On Thu, Jan 02, 2020 at 08:14:10PM +0200, Timo Myyrä wrote:
> Solene Rapenne <sol...@perso.pw> writes:
>
> > On Wed, Jan 01, 2020 at 07:00:45PM +0200, Timo Myyrä wrote:
> >
> >> Hi,
> >>
> >> Here's an attempt to update sbcl to latest version.
> >> Before adding the new patch I got consistent test failures in inpure timer
> >> test
> >> "(:WITH-TIMEOUT :MANY-AT-THE-SAME-TIME".
> >>
> >> After adding the patch to unix.lisp the tests have passed twice on amd64.
> >> Does this look OK, does the tests work on other platforms?
> >>
> >> Timo
> >>
> >
> > I'm ok and will commit it if maintainer is ok too
>
> Heres revised diff with upstream backports. I still think we're better off
> waiting next release so we don't have to include these patches but it can't
> hurt
> to test these to see they indeed fix the issue.
>
> Tested clisp bootstrapped on amd64 and tests passed.
>
> timo
I sent a reply a few days ago but it's gone missing, so let's try again.
The timing-related tests can be a bit fragile, I think the
gettimeofday() change is only hiding a heisenbug in the tests for
you. Personally, I think this is a test bug and not a real sbcl
problem and isn't really worth patching.
Additionally, you've added an empty html doc directory to the
PLIST. How about this, which rmdir's the directory so it doesn't get
re-added? I've tested and i386/macppc test results aren't worse.
Index: Makefile
===================================================================
RCS file: /cvs/ports/lang/sbcl/Makefile,v
retrieving revision 1.43
diff -u -r1.43 Makefile
--- Makefile 16 Sep 2019 06:24:18 -0000 1.43
+++ Makefile 2 Jan 2020 18:00:11 -0000
@@ -6,7 +6,7 @@
COMMENT= compiler and runtime system for ANSI Common Lisp
-V = 1.5.5
+V = 2.0.0
DISTNAME= sbcl-${V}-source
PKGNAME= sbcl-${V}
WRKDIST= ${WRKDIR}/sbcl-${V}
@@ -82,6 +82,7 @@
post-install:
chown -R 0:0 ${PREFIX}/lib/sbcl
+ rmdir ${PREFIX}/share/doc/sbcl/html
do-test:
cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} DONT_CLEAN_SBCL_CONTRIB=1 \
Index: distinfo
===================================================================
RCS file: /cvs/ports/lang/sbcl/distinfo,v
retrieving revision 1.18
diff -u -r1.18 distinfo
--- distinfo 16 Sep 2019 06:24:18 -0000 1.18
+++ distinfo 2 Jan 2020 18:00:11 -0000
@@ -1,2 +1,2 @@
-SHA256 (sbcl-1.5.5-source.tar.bz2) =
y0f65qhvDFxXQxYE+05fEcioI/lM4SjVaLh3D8W8quI=
-SIZE (sbcl-1.5.5-source.tar.bz2) = 6351480
+SHA256 (sbcl-2.0.0-source.tar.bz2) =
kDaSVoBdQ3yCq5vauaQQB29XgQpQuysijeTmyJJpL88=
+SIZE (sbcl-2.0.0-source.tar.bz2) = 6457217
