Stuart Henderson <s...@spacehopper.org> writes:
> On 2020/01/21 18:22, Xiyue Deng wrote:
>> Hi,
>>
>> Currently mu requires ports-clang which I think is because there was a
>> time that GCC 4.9 didn't support C++14. Now that GCC is on 8.3, mu can
>> be unblocked for GCC archs as well. I didn't change patch level as I
>> think there is no visible change, but correct me if I'm wrong.
>>
>> Tested on mips64el/loongson.
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/mail/mu/Makefile,v
>> retrieving revision 1.18
>> diff -u -p -r1.18 Makefile
>> --- Makefile 21 Jul 2019 00:10:04 -0000 1.18
>> +++ Makefile 22 Jan 2020 02:16:59 -0000
>> @@ -14,7 +14,7 @@ PERMIT_PACKAGE= Yes
>>
>> WANTLIB+= assuan c ffi gio-2.0 glib-2.0 gmime-3.0 gmodule-2.0
>> WANTLIB+= gobject-2.0 gpg-error gpgme gthread-2.0 iconv
>> -WANTLIB+= intl json-glib-1.0 m pcre pthread ${COMPILER_LIBCXX}
>> +WANTLIB+= intl json-glib-1.0 m pcre pthread
>> WANTLIB+= uuid xapian z
>
> ${COMPILER_LIBCXX} should stay in the list. Seems that idn2 and unistring
> should be added too.
>
> Also needs a REVISION bump.
>
> btw your mail was quoted-printable encoded and the patch couldn't be applied
> directly.
>Thanks for reviewing the patch! This seems to be caused by PGP signing. Is there a way to workaround this or I need to attach the patch instead of inlining it when sending signed emails? >> # C++14 required >> -COMPILER= base-clang ports-clang >> +COMPILER= base-clang ports-gcc > > This part is ok with me with the bump added. > >> AUTOCONF_VERSION= 2.69 >> AUTOMAKE_VERSION= 1.15
signature.asc
Description: PGP signature
